mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: Luo Jiaxing <luojiaxing@huawei.com>, <martin.petersen@oracle.com>,
	<jejb@linux.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<john.garry@huawei.com>, <chenxiang66@hisilicon.com>,
	<linuxarm@huawei.com>
Subject: Re: [PATCH v1 2/2] {topost} scsi: libsas: check link status at ATA prereset() ops
Date: Wed, 22 Jul 2020 18:31:30 +0800	[thread overview]
Message-ID: <1658a661-bf58-85b6-8475-7c29dce63eb3@huawei.com> (raw)
In-Reply-To: <1595408643-63011-3-git-send-email-luojiaxing@huawei.com>


在 2020/7/22 17:04, Luo Jiaxing 写道:
> We found out that libata will retry reset even if SATA disk is unpluged. We
> should report offline to libata to avoid meaningless reset on the disk.
> Libata provide an ops of prereset() for this purpose, it was called by
> ata_eh_reset() only and used to decide whether to skip reset base on the
> return value of it.
> 
> We check status of phy and disk at prereset(). If disk is already offline
> or phy is disabled, we return -ENOENT to libata to skip disk reset.
> 
> As prereset() should be best-effort, we should continue to try disk reset
> beyond the situation we mentioned before.
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
> Reviewed-by: John Garry <john.garry@huawei.com>
> ---
>   drivers/scsi/libsas/sas_ata.c | 16 +++++++++++++++-
>   1 file changed, 15 insertions(+), 1 deletion(-)
> 

The same as the first one, after fix the  subject:

Reviewed-by: Jason Yan <yanaijie@huawei.com>


  reply	other threads:[~2020-07-22 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  9:04 [PATCH v1 0/2] scsi: libsas: An improvement on error handle and tidy-up Luo Jiaxing
2020-07-22  9:04 ` [PATCH v1 1/2] {topost} scsi: libsas: delete postreset at sas_sata_ops Luo Jiaxing
2020-07-22 10:27   ` Jason Yan
2020-07-22  9:04 ` [PATCH v1 2/2] {topost} scsi: libsas: check link status at ATA prereset() ops Luo Jiaxing
2020-07-22 10:31   ` Jason Yan [this message]
2020-07-25  2:50 ` [PATCH v1 0/2] scsi: libsas: An improvement on error handle and tidy-up Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1658a661-bf58-85b6-8475-7c29dce63eb3@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=luojiaxing@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®