From: Kalle Valo <kvalo@kernel.org>
To: williamsukatube@163.com
Cc: tony0620emma@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
William Dean <williamsukatube@gmail.com>,
Hacash Robot <hacashRobot@santino.com>
Subject: Re: wifi: rtw88: check the return value of alloc_workqueue()
Date: Fri, 29 Jul 2022 13:35:59 +0000 (UTC) [thread overview]
Message-ID: <165910175801.2014.14758943115910688556.kvalo@kernel.org> (raw)
In-Reply-To: <20220723063756.2956189-1-williamsukatube@163.com>
williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@gmail.com>
>
> The function alloc_workqueue() in rtw_core_init() can fail, but
> there is no check of its return value. To fix this bug, its return value
> should be checked with new error handling code.
>
> Fixes: fe101716c7c9d ("rtw88: replace tx tasklet with work queue")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
42bbf810e155 wifi: rtw88: check the return value of alloc_workqueue()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220723063756.2956189-1-williamsukatube@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-07-29 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 6:37 [PATCH] " williamsukatube
2022-07-26 2:38 ` Ping-Ke Shih
2022-07-29 13:35 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165910175801.2014.14758943115910688556.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hacashRobot@santino.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tony0620emma@gmail.com \
--cc=williamsukatube@163.com \
--cc=williamsukatube@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®