From: Li Zhijian <lizhijian@fujitsu.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Zhu Yanjun <zyjzyj2000@gmail.com>,
"Leon Romanovsky" <leon@kernel.org>, <linux-rdma@vger.kernel.org>
Cc: Xiao Yang <yangx.jy@fujitsu.com>, <y-goto@fujitsu.com>,
Bob Pearson <rpearsonhpe@gmail.com>,
Mark Bloch <mbloch@nvidia.com>,
Aharon Landau <aharonl@nvidia.com>, Tom Talpey <tom@talpey.com>,
<tomasz.gromadzki@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-kernel@vger.kernel.org>,
Li Zhijian <lizhijian@fujitsu.com>
Subject: [PATCH v4 2/6] RDMA/rxe: Allow registering persistent flag for pmem MR only
Date: Fri, 5 Aug 2022 07:46:15 +0000 [thread overview]
Message-ID: <1659685579-2-3-git-send-email-lizhijian@fujitsu.com> (raw)
In-Reply-To: <1659685579-2-1-git-send-email-lizhijian@fujitsu.com>
Memory region could at most support 2 access flags:
IB_ACCESS_FLUSH_PERSISTENT and IB_ACCESS_FLUSH_GLOBAL_VISIBILITY
But we only allow user to register persistent flush flags to the pmem MR
that supports the ability of persisting data across power cycles.
So register a persistent access flag to a non-pmem MR will be rejected
by kernel.
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
v2: update commit message, get rid of confusing ib_check_flush_access_flags() # Tom
---
drivers/infiniband/sw/rxe/rxe_mr.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 9e3e1a18f2dd..24ca014cdecd 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -113,6 +113,13 @@ void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr)
mr->type = IB_MR_TYPE_DMA;
}
+static bool vaddr_in_pmem(char *vaddr)
+{
+ return REGION_INTERSECTS ==
+ region_intersects(virt_to_phys(vaddr), 1, IORESOURCE_MEM,
+ IORES_DESC_PERSISTENT_MEMORY);
+}
+
int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
int access, struct rxe_mr *mr)
{
@@ -123,6 +130,7 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
int num_buf;
void *vaddr;
int err;
+ bool first = true, is_pmem = false;
int i;
umem = ib_umem_get(pd->ibpd.device, start, length, access);
@@ -167,6 +175,11 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
goto err_cleanup_map;
}
+ if (first) {
+ first = false;
+ is_pmem = vaddr_in_pmem(vaddr);
+ }
+
buf->addr = (uintptr_t)vaddr;
buf->size = PAGE_SIZE;
num_buf++;
@@ -175,6 +188,12 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
}
}
+ if (!is_pmem && access & IB_ACCESS_FLUSH_PERSISTENT) {
+ pr_warn("Cannot register IB_ACCESS_FLUSH_PERSISTENT for non-pmem memory\n");
+ err = -EINVAL;
+ goto err_release_umem;
+ }
+
mr->ibmr.pd = &pd->ibpd;
mr->umem = umem;
mr->access = access;
--
2.31.1
next prev parent reply other threads:[~2022-08-05 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 7:46 [PATCH v4 0/6] RDMA/rxe: Add RDMA FLUSH operation Li Zhijian
2022-08-05 7:46 ` [PATCH v4 1/6] RDMA: Allow registering MR with flush access flags Li Zhijian
2022-08-05 7:46 ` Li Zhijian [this message]
2022-08-05 7:46 ` [PATCH v4 3/6] RDMA/rxe: Implement RC RDMA FLUSH service in requester side Li Zhijian
2022-08-05 7:46 ` [PATCH v4 4/6] RDMA/rxe: Implement flush execution in responder side Li Zhijian
2022-08-05 7:55 ` [PATCH v4 5/6] RDMA/rxe: Implement flush completion Li Zhijian
2022-08-05 7:55 ` [PATCH v4 6/6] RDMA/rxe: Enable RDMA FLUSH capability for rxe device Li Zhijian
2022-08-26 13:37 ` [PATCH v4 0/6] RDMA/rxe: Add RDMA FLUSH operation Jason Gunthorpe
2022-08-29 1:36 ` yangx.jy
2022-08-29 1:40 ` yangx.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1659685579-2-3-git-send-email-lizhijian@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=aharonl@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®