From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9289023D2AB for ; Wed, 19 Nov 2025 14:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563778; cv=none; b=A/IHEcC1tbA+B7kqwouHPFSsuGhCWe7R6GApLgeUrWkz8ECL2Znk9E6ha1eizDfmFg/YLjmXd3it9BjX9TLw1iImGHl3tY7yVrIhxBhYi7IGjCzz112rFZ1QBs3yO9YIZRswIG8ArN2kK+CnGLwhR3eJaAYE0A5ChJn1Ij8AyQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563778; c=relaxed/simple; bh=JRyZCdgunre47fOEJ3dnQtncks6xVvgMZR8IbbBf9Xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZtiJxDGt3/7l6r5uq9Gy5KTz6YXXC9Q0dZbVwocNnt/QfeYPWO6msKNlCbBD1EkqLlW6GZHOV7xGaB5YlckGvAHoFCkmp8GEoI1x1NMF8lobiLjeSNQG+WxxTb/gQPyLn1AlVmH9LuED1LvXERPdesaBZ6lNZurJHTORAPEZUQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DfoBQR1i; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DfoBQR1i" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42bb288c1bfso3021635f8f.2 for ; Wed, 19 Nov 2025 06:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763563775; x=1764168575; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=PvzXT1PDok/yQbdLDJPIegEZrHBcAnX7M9j9AL4admk=; b=DfoBQR1ic1vxOlejOkbwAXIR1N2jKZGh1SRmMidrcDM1xYkP0BMjxrMal6KAdmMcfB 7MkFXdFO9Bt+F3kSRqEgSrggbp22RQhgAOxNN7U1J6tvGPBTBaEcjAhgd5lNbdA7knEE iZeJQoiCxJIRl2N2R/g+wnCd4GbR6HbZEtCVsaD5nIf7/W+XBCTBTihJbhg+5cyyVWIq gJ+uOZGNlxhRLjZLQwY7/sjAHPLTY8YU/w9cpIbMU8jPgrp3Cx/6HpND4Yr4mL9Qcty3 CTeYVRkRF/BpMZNwzb1G+y5J90cc2ZClajmFdAsT8WbO5BqC2vzmT1/XMUHwN+9Lekzt 5nIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763563775; x=1764168575; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PvzXT1PDok/yQbdLDJPIegEZrHBcAnX7M9j9AL4admk=; b=GPzp/HF46Tugsq/+I2/ooVvfzgU4AJCOcb12J3wj4rNGBSXO2aMELbdSSqk9h40TYQ z9eivpeYpc9/bF8NRBoLv5HvdZsH1GkaTOVISXt3HrIoLqu/jODNIPMHbTHttK+N21U/ QyyxrUiA4BKkoh88IvfInWLabfhUK0JFpVcBvjeAY01kHE++gqG7fLee1wHcopOJauOz VirqvOa1udHoRZpli2TQWaqVZNHLC/zfewdeyZMBBEC2AG/3eapjmJN05kJbOat2rIqk 6mry598GnExnjr7RVGT+TnPUPHzRKJu+LbmQlHlcFw0JmohvnwrBZT+JHljhhO62FcWm fKDw== X-Forwarded-Encrypted: i=1; AJvYcCXgyr/5+jJ0+w+Z8wnrzgOO7ERWEozx+wv8ePac4ACOs67I3eoZ+tQZNF8h8ytFbKg5zwwmYzbD74dhQ+A=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5hjEaL4HNyl4SKt3mewNsfRBIkzZWslmon18BgdE+A59UIRGH xHgMDxHuYta2c1bTLElNwOvT4vjyMjT7BotSGsZlnrPOFER6DkR5MXXJLRAhMFNTGT8= X-Gm-Gg: ASbGncube752WB5INYz3kK95iigSFYY42ACZSU4YAUzjyhVuXBDgjiX8rO3oOyHGOUQ mwA59kuqSun3R7jzg0oU2f5IyuemIGLVN6NG+awzK7GUH5IANPGnFUVMlgfTGDfRUMrLEu9SKpx +SKE1BQFKfRrRrwEFkjZKFh862i8Vd+TB76CZFpUEbOnNz3QF4YC720jCsmpl+yhF0yHKAtNvl5 Fi5+xFE8HiF7xJCbZsDEjD5UZ+VrhslqA043araVl5Mqoi0U2ocIZYAf9XFgCCS9EetyPGL8QOL nKrkMfnHeR8Y6AzTrIqgveps2dNw6aAoDu9t/F/w3uzk+9+VuEFeb1P63Fq4NURomy9sj264TWr F98dW5yRVrESXOxVxRViWRfrNsAW4ht930wZcK9eUAHY2AQ7sb9bZuiUgZYVCNl0hfK0O3jqF7R Bn7+g//sLzcFLDL/kohk4hXKZya9QcBsl7rxf96Yav740T3ftEZhcV8RHMsPWux+/TyzBU/Q396 g== X-Google-Smtp-Source: AGHT+IF/SJMMbWEgRFwYg9CHGo9ekhafPDlPY7JxyauGM1SXhVQ1hoTLFavIWNHOvylWguN3KYxCQQ== X-Received: by 2002:a5d:584c:0:b0:42b:4194:48cf with SMTP id ffacd0b85a97d-42b593991f4mr19216195f8f.52.1763563774737; Wed, 19 Nov 2025 06:49:34 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:263d:925b:a11f:ae36? ([2a01:e0a:3d9:2080:263d:925b:a11f:ae36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b62dsm38408563f8f.24.2025.11.19.06.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 06:49:34 -0800 (PST) Message-ID: <165c7488-897b-4500-a7dc-a212cd64923e@linaro.org> Date: Wed, 19 Nov 2025 15:49:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check To: Claudiu , yoshihiro.shimoda.uh@renesas.com, vkoul@kernel.org, kishon@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de Cc: linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> <20251119120418.686224-2-claudiu.beznea.uj@bp.renesas.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251119120418.686224-2-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/19/25 13:04, Claudiu wrote: > From: Claudiu Beznea > > Move the check of phy_data->init_bus from rcar_gen3_phy_usb2_init_bus() > to rcar_gen3_phy_usb2_probe() to avoid having it duplicated in both the > probe path and the upcoming resume code. This is a preparatory patch. > > Signed-off-by: Claudiu Beznea > --- > > Changes in v2: > - none; this patch is new > > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > index a38ead7c8055..b9d5bb52e02c 100644 > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > @@ -782,6 +782,9 @@ static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel) > int ret; > u32 val; > > + if (!channel->phy_data->init_bus) > + return 0; > + > rstc = devm_reset_control_array_get_shared(dev); > if (IS_ERR(rstc)) > return PTR_ERR(rstc); > @@ -861,11 +864,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, channel); > channel->dev = dev; > > - if (channel->phy_data->init_bus) { > - ret = rcar_gen3_phy_usb2_init_bus(channel); > - if (ret) > - goto error; > - } > + ret = rcar_gen3_phy_usb2_init_bus(channel); > + if (ret) > + goto error; > > spin_lock_init(&channel->lock); > for (i = 0; i < NUM_OF_PHYS; i++) { Reviewed-by: Neil Armstrong