From: margeyang <marge.yang@synaptics.corp-partner.google.com>
To: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
benjamin.tissoires@redhat.com
Cc: marge.yang@tw.synaptics.com, derek.cheng@tw.synaptics.com,
vincent.huang@tw.synaptics.com,
Marge Yang <marge.yang@synaptics.corp-partner.google.com>
Subject: [PATCH V3] HID: HID-rmi - ignore to rmi_hid_read_block after system resumes.
Date: Thu, 11 Aug 2022 10:58:32 +0800 [thread overview]
Message-ID: <1660186712-2598-1-git-send-email-marge.yang@synaptics.corp-partner.google.com> (raw)
From: Marge Yang <marge.yang@synaptics.corp-partner.google.com>
The interrupt GPIO will be pulled down once
after RMI driver reads this command(Report ID:0x0A).
It will cause "Dark resume test fail" for chromebook device.
Hence, TP driver will ignore rmi_hid_read_block function once
after system resumes.
Signed-off-by: Marge Yang<marge.yang@synaptics.corp-partner.google.com>
---
drivers/hid/hid-rmi.c | 14 ++++++++++++--
include/linux/rmi.h | 2 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 311eee599ce9..fdaf2c4ce181 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -203,7 +203,13 @@ static int rmi_hid_read_block(struct rmi_transport_dev *xport, u16 addr,
if (ret < 0)
goto exit;
}
-
+ if (xport->ignoreonce == 1) {
+ dev_err(&hdev->dev,
+ "ignoreonce (%d)\n",
+ xport->ignoreonce);
+ xport->ignoreonce = 0;
+ goto exit;
+ }
for (retries = 5; retries > 0; retries--) {
data->writeReport[0] = RMI_READ_ADDR_REPORT_ID;
data->writeReport[1] = 0; /* old 1 byte read count */
@@ -468,8 +474,12 @@ static int rmi_post_resume(struct hid_device *hdev)
ret = hid_hw_open(hdev);
if (ret)
return ret;
-
+ // Avoid to read rmi_hid_read_block once after system resumes.
+ // The interrupt will be pulled down
+ // after RMI Read command(Report ID:0x0A).
+ data->xport.ignoreonce = 1;
ret = rmi_reset_attn_mode(hdev);
+ data->xport.ignoreonce = 0;
if (ret)
goto out;
diff --git a/include/linux/rmi.h b/include/linux/rmi.h
index ab7eea01ab42..24f63ad00970 100644
--- a/include/linux/rmi.h
+++ b/include/linux/rmi.h
@@ -270,6 +270,8 @@ struct rmi_transport_dev {
struct rmi_device_platform_data pdata;
struct input_dev *input;
+
+ int ignoreonce;
};
/**
--
2.22.0.windows.1
next reply other threads:[~2022-08-11 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 2:58 margeyang [this message]
2022-08-11 4:20 ` Dmitry Torokhov
2022-08-11 7:26 ` Marge Yang
2022-08-11 7:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660186712-2598-1-git-send-email-marge.yang@synaptics.corp-partner.google.com \
--to=marge.yang@synaptics.corp-partner.google.com \
--cc=benjamin.tissoires@redhat.com \
--cc=derek.cheng@tw.synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marge.yang@tw.synaptics.com \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®