From: Jens Axboe <axboe@kernel.dk>
To: rafaelmendsr@gmail.com, hare@suse.de
Cc: linux-block@vger.kernel.org, hdanton@sina.com,
linux-kernel@vger.kernel.org,
syzbot+31c9594f6e43b9289b25@syzkaller.appspotmail.com
Subject: Re: [PATCH] block: Do not call blk_put_queue() if gendisk allocation fails
Date: Fri, 12 Aug 2022 06:42:11 -0600 [thread overview]
Message-ID: <166030813180.891934.12259200339444300073.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220811232338.254673-1-rafaelmendsr@gmail.com>
On Thu, 11 Aug 2022 20:23:37 -0300, Rafael Mendonca wrote:
> Commit 6f8191fdf41d ("block: simplify disk shutdown") removed the call
> to blk_get_queue() during gendisk allocation but missed to remove the
> corresponding cleanup code blk_put_queue() for it. Thus, if the gendisk
> allocation fails, the request_queue refcount gets decremented and
> reaches 0, causing blk_mq_release() to be called with a hctx still
> alive. That triggers a WARNING report, as found by syzkaller:
>
> [...]
Applied, thanks!
[1/1] block: Do not call blk_put_queue() if gendisk allocation fails
commit: aa0c680c3aa96a5f9f160d90dd95402ad578e2b0
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-08-12 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 23:23 Rafael Mendonca
2022-08-12 5:42 ` Christoph Hellwig
2022-08-12 12:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166030813180.891934.12259200339444300073.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hdanton@sina.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafaelmendsr@gmail.com \
--cc=syzbot+31c9594f6e43b9289b25@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®