mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] teach netconsole how to do syslog
Date: Fri, 25 Jun 2004 14:47:18 -0400	[thread overview]
Message-ID: <16604.29494.41418.239128@segfault.boston.redhat.com> (raw)
In-Reply-To: <20040625183935.GC25826@waste.org>

==> Regarding Re: [patch] teach netconsole how to do syslog; Matt Mackall <mpm@selenic.com> adds:

mpm> On Fri, Jun 25, 2004 at 01:57:38PM -0400, Jeff Moyer wrote:
>> Hello,
>> 
>> Here's a patch which adds the option to send messages to a remote
>> syslog, enabled via the do_syslog= module parameter.  Currently logs
>> everything at info (as did the original netconsole module).  Patch is
>> against 2.6.6, though should apply to later.

mpm> Well as it stands, it's already syslog compatible, as the priority
mpm> level component of the syslog protocol is optional. I've made a point
mpm> of _defining_ the netconsole protocol as syslog (note the default
mpm> port) so that this could be done at a later date. Thus, I don't think
mpm> a new command line option is necessary.

Well, the way it is coded currently does not usually give a full line of
output on each line in my system log:

Jun 25 14:41:18 remote-host HELP : 
Jun 25 14:41:18 remote-host SysRq : 
Jun 25 14:41:18 remote-host loglevel0-8 
Jun 25 14:41:18 remote-host reBoot 
Jun 25 14:41:18 remote-host Crash 
Jun 25 14:41:18 remote-host tErm 
Jun 25 14:41:18 remote-host kIll 
Jun 25 14:41:18 remote-host saK 
Jun 25 14:41:18 remote-host showMem 
Jun 25 14:41:18 remote-host powerOff 
Jun 25 14:41:18 remote-host showPc 
Jun 25 14:41:18 remote-host unRaw 
Jun 25 14:41:18 remote-host Sync 
Jun 25 14:41:18 remote-host showTasks 
Jun 25 14:41:18 remote-host Unmount 
Jun 25 14:41:18 remote-host  

mpm> On the other hand, for this to have real value, we need to provide
mpm> real priority levels. Which means we need to plug it in higher in the
mpm> printk framework so that we a) get all messages by default and b) get
mpm> them before the levels are stripped off. I had this in an earlier
mpm> version but dropped it as being too intrusive for 2.6.0 merger.

And are you still in favor of this?  Want to post the code?

mpm> Also, if we're going to go to the trouble of being more completely
mpm> syslog-like, it's very useful (and trivial) to throw in the hostname
mpm> as well. Timestamp is slightly more difficult, but also worth
mpm> considering.

Hostname shows up by default with my syslogd.

-Jeff

  reply	other threads:[~2004-06-25 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25 17:57 Jeff Moyer
2004-06-25 18:39 ` Matt Mackall
2004-06-25 18:47   ` Jeff Moyer [this message]
2004-06-25 19:11     ` Matt Mackall
2004-06-26  2:26       ` Keith Owens
2004-06-26  3:48         ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16604.29494.41418.239128@segfault.boston.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®