From: David Howells <dhowells@redhat.com>
To: Anastasia Belova <abelova@astralinux.ru>
Cc: dhowells@redhat.com, Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] afs: remove redundant overwriting of ret
Date: Thu, 21 Dec 2023 14:10:49 +0000 [thread overview]
Message-ID: <1660754.1703167849@warthog.procyon.org.uk> (raw)
In-Reply-To: <20231221085849.1463-1-abelova@astralinux.ru>
Anastasia Belova <abelova@astralinux.ru> wrote:
> @@ -409,7 +409,6 @@ static int afs_update_cell(struct afs_cell *cell)
> if (ret == -ENOMEM)
> goto out_wake;
>
> - ret = -ENOMEM;
> vllist = afs_alloc_vlserver_list(0);
> if (!vllist)
> goto out_wake;
This isn't a sufficient fix.
Yes, you're right, we need to keep ret - but we do need to set -ENOMEM if
!vllist if ret does not hold an error.
David
prev parent reply other threads:[~2023-12-21 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 8:58 Anastasia Belova
2023-12-21 14:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660754.1703167849@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=abelova@astralinux.ru \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®