mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com
Cc: linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC64: (resend) Janitor signature of rtas_call() routine
Date: Wed, 30 Jun 2004 21:33:16 +1000	[thread overview]
Message-ID: <16610.42236.698377.733729@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040629154202.N21634@forte.austin.ibm.com>

Linas,

> Can you please apply the following patch to the ameslab ppc64
> tree, and/or roll it upwards to the marclello 2.6 tree?
> This path is 100% pure cleanup; no functional changes.
> 
> I got irritated when I was given a -1 that was cast to an unsigned
> int that was then cast to a signed (64-bit) long, and so I received
> a value of 4 billion instead of -1.  This patch fixes this insanity.
> 
> Different files were treating this return code as being signed
> or unsigned, 32-bit or 64-bit.  The 'real' return code is always
> a signed 32-bit quantity, so this patch just makes the usage
> consistent across the board.

I beat you to the punch on this one, I'm afraid. :)  I changed
rtas_call to return an int in the prom cleanup patch I sent to Andrew
last week.  You did spot a few places that I missed though, so I'll
send Andrew a patch to fix those up shortly.

Regards,
Paul.



  reply	other threads:[~2004-06-30 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-29 20:42 linas
2004-06-30 11:33 ` Paul Mackerras [this message]
2004-06-30 17:53   ` linas
2004-06-30 23:14     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16610.42236.698377.733729@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®