From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com
Cc: linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6 PPC64 EEH unbalanced dev_get/put calls
Date: Sat, 3 Jul 2004 15:13:02 +1000 [thread overview]
Message-ID: <16614.16478.9599.463185@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040702134539.W21634@forte.austin.ibm.com>
Linas,
> This patch fixes some unbalanaced usage of pci_dev_get()/pci_dev_put() calls
> in the eeh code. The old code had too many calls to dev_put, which could
> cause memory structs to be freed prematurely, possibly leading to bad
> bad pointer derefs in certain cases.
When I apply this I end up with one pci_dev_get() call in
__pci_addr_cache_insert_device and no pci_dev_put() calls. That can't
be right, surely? If it is it needs a big fat comment explaining why.
> Cross-ref LTC bug 9283
Confused - that's the bug about not using ibm,fw-phb-id.
Paul.
next prev parent reply other threads:[~2004-07-03 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 18:45 linas
2004-07-03 5:13 ` Paul Mackerras [this message]
2004-07-06 16:18 ` linas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16614.16478.9599.463185@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®