From: Maxime Ripard <maxime@cerno.tech>
To: airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de,
dakr@redhat.com, mripard@kernel.org
Cc: Maxime Ripard <maxime@cerno.tech>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH drm-misc-next v3 0/4] Fixes for vc4 hotplug rework
Date: Thu, 25 Aug 2022 09:47:14 +0200 [thread overview]
Message-ID: <166141363051.357827.14816951155409708010.b4-ty@cerno.tech> (raw)
In-Reply-To: <20220824161327.330627-1-dakr@redhat.com>
On Wed, 24 Aug 2022 18:13:23 +0200, Danilo Krummrich wrote:
> I've found a few potential issues left after the hotplug rework.
>
> In vc4_hdmi.c we're missing two mutex_unlock() calls when the device is
> unplugged.
>
> vc4_crtc and vc4_plane seem to miss some drm_dev_enter()/drm_dev_exit() calls
> to protect against resource access after the device/driver is unbound, but the
> DRM potentially isn't freed yet and userspace can still call into the driver.
>
> [...]
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
prev parent reply other threads:[~2022-08-25 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 16:13 Danilo Krummrich
2022-08-24 16:13 ` [PATCH drm-misc-next v3 1/4] drm/vc4: hdmi: unlock mutex when device is unplugged Danilo Krummrich
2022-08-24 16:13 ` [PATCH drm-misc-next v3 2/4] drm/vc4: plane: protect device resources after removal Danilo Krummrich
2022-08-24 16:13 ` [PATCH drm-misc-next v3 3/4] drm/vc4: crtc: " Danilo Krummrich
2022-08-24 16:13 ` [PATCH drm-misc-next v3 4/4] drm/vc4: hvs: protect drm_print_regset32() Danilo Krummrich
2022-08-25 7:47 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166141363051.357827.14816951155409708010.b4-ty@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®