From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbbIIAgx (ORCPT ); Tue, 8 Sep 2015 20:36:53 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:43837 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754173AbbIIAgo (ORCPT ); Tue, 8 Sep 2015 20:36:44 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, preeti.lkml@gmail.com, open list Subject: Re: [PATCH V2 4/9] cpufreq: governor: Drop __gov_queue_work() Date: Wed, 09 Sep 2015 03:04:34 +0200 Message-ID: <1661501.6U4Cb8rbZs@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150908020044.GZ26760@linux> References: <288361840.gGA5ernLiT@vostro.rjw.lan> <20150908020044.GZ26760@linux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 08, 2015 07:30:44 AM Viresh Kumar wrote: > On 08-09-15, 03:15, Rafael J. Wysocki wrote: > > On Monday, July 27, 2015 05:58:09 PM Viresh Kumar wrote: > > > __gov_queue_work() isn't required anymore and can be merged with > > > gov_queue_work(). Do it. > > > > > > Signed-off-by: Viresh Kumar > > > > Quite frankly I don't see the point. > > But isn't that just an unnecessary wrapper ? It isn't a wrapper, just a separation of code executed in each step of the loop. There's nothing wrong with having a separate function for that in principle. I wouldn't make a fuss about that if that was new code even, so I don't see why we should change it. > > I'd even remove the inline from its definition and let the compiler decide > > what to do with it. > > What if the compiler decides to link it? Why add a function call for > (almost) no use? If the compiler does that, let it do it. :-) If you think that you can outsmart the compiler people by doing such optimizations at this level manually, you're likely wrong. Serious man-hours go into making that stuff work as well as it can in compilers. Thanks, Rafael