From: Mark Brown <broonie@kernel.org>
To: dianders@chromium.org
Cc: lgirdwood@gmail.com, ahalaney@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH v2 1/2] regulator: core: Require regulator drivers to check uV for get_optimum_mode()
Date: Sun, 28 Aug 2022 22:03:56 +0100 [thread overview]
Message-ID: <166172063687.600288.12015393675226828521.b4-ty@kernel.org> (raw)
In-Reply-To: <20220824142229.RFT.v2.1.I137e6bef4f6d517be7b081be926059321102fd3d@changeid>
On Wed, 24 Aug 2022 14:22:56 -0700, Douglas Anderson wrote:
> The get_optimum_mode() for regulator drivers is passed the input
> voltage and output voltage as well as the current. This is because, in
> theory, the optimum mode can depend on all three things.
>
> It turns out that for all regulator drivers in mainline only the
> current is looked at when implementing get_optimum_mode(). None of the
> drivers take the input or output voltage into account. Despite the
> fact that none of the drivers take the input or output voltage into
> account, though, the regulator framework will error out before calling
> into get_optimum_mode() if it doesn't know the input or output
> voltage.
>
> [...]
Applied to
broonie/regulator.git for-next
Thanks!
[1/2] regulator: core: Require regulator drivers to check uV for get_optimum_mode()
commit: 55841199050d0c6c44eb7f24717816e6e372599f
[2/2] regulator: core: Don't err if allow-set-load but no allowed-modes
commit: 57919f4a2ea47f75ac6117f7d99831f7fbd89bc7
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2022-08-28 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 21:22 Douglas Anderson
2022-08-24 21:22 ` [RFT PATCH v2 2/2] regulator: core: Don't err if allow-set-load but no allowed-modes Douglas Anderson
2022-08-25 15:14 ` Andrew Halaney
2022-08-25 16:43 ` Doug Anderson
2022-08-25 17:00 ` Andrew Halaney
2022-08-25 15:15 ` [RFT PATCH v2 1/2] regulator: core: Require regulator drivers to check uV for get_optimum_mode() Andrew Halaney
2022-08-28 21:03 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166172063687.600288.12015393675226828521.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=ahalaney@redhat.com \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®