From: "tip-bot2 for Anshuman Khandual" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
James Clark <james.clark@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/core] perf: Add system error and not in transaction branch types
Date: Mon, 29 Aug 2022 07:50:02 -0000 [thread overview]
Message-ID: <166175940238.401.10445533628526721258.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20220824044822.70230-2-anshuman.khandual@arm.com>
The following commit has been merged into the perf/core branch of tip:
Commit-ID: a724ec82966d57e4b5d36341d3e3dc1a3c011564
Gitweb: https://git.kernel.org/tip/a724ec82966d57e4b5d36341d3e3dc1a3c011564
Author: Anshuman Khandual <anshuman.khandual@arm.com>
AuthorDate: Wed, 24 Aug 2022 10:18:15 +05:30
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 29 Aug 2022 09:42:41 +02:00
perf: Add system error and not in transaction branch types
This expands generic branch type classification by adding two more entries
there in i.e system error and not in transaction. This also updates the x86
implementation to process X86_BR_NO_TX records as appropriate. This changes
branch types reported to user space on x86 platform but it should not be a
problem. The possible scenarios and impacts are enumerated here.
--------------------------------------------------------------------------
| kernel | perf tool | Impact |
--------------------------------------------------------------------------
| old | old | Works as before |
--------------------------------------------------------------------------
| old | new | PERF_BR_UNKNOWN is processed |
--------------------------------------------------------------------------
| new | old | PERF_BR_NO_TX is blocked via old PERF_BR_MAX |
--------------------------------------------------------------------------
| new | new | PERF_BR_NO_TX is recognized |
--------------------------------------------------------------------------
When PERF_BR_NO_TX is blocked via old PERF_BR_MAX (new kernel with old perf
tool) the user space might throw up an warning complaining about an
unrecognized branch types being reported, but it's expected. PERF_BR_SERROR
& PERF_BR_NO_TX branch types will be used for BRBE implementation on arm64
platform.
PERF_BR_NO_TX complements 'abort' and 'in_tx' elements in perf_branch_entry
which represent other transaction states for a given branch record. Because
this completes the transaction state classification.
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: James Clark <james.clark@arm.com>
Link: https://lkml.kernel.org/r/20220824044822.70230-2-anshuman.khandual@arm.com
---
arch/x86/events/utils.c | 2 +-
include/uapi/linux/perf_event.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/events/utils.c b/arch/x86/events/utils.c
index e013243..5f5617a 100644
--- a/arch/x86/events/utils.c
+++ b/arch/x86/events/utils.c
@@ -225,7 +225,7 @@ static int branch_map[X86_BR_TYPE_MAP_MAX] = {
PERF_BR_IND_CALL, /* X86_BR_IND_CALL */
PERF_BR_UNKNOWN, /* X86_BR_ABORT */
PERF_BR_UNKNOWN, /* X86_BR_IN_TX */
- PERF_BR_UNKNOWN, /* X86_BR_NO_TX */
+ PERF_BR_NO_TX, /* X86_BR_NO_TX */
PERF_BR_CALL, /* X86_BR_ZERO_CALL */
PERF_BR_UNKNOWN, /* X86_BR_CALL_STACK */
PERF_BR_IND, /* X86_BR_IND_JMP */
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 30a4723..a79cc0e 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -253,6 +253,8 @@ enum {
PERF_BR_COND_RET = 10, /* conditional function return */
PERF_BR_ERET = 11, /* exception return */
PERF_BR_IRQ = 12, /* irq */
+ PERF_BR_SERROR = 13, /* system error */
+ PERF_BR_NO_TX = 14, /* not in transaction */
PERF_BR_MAX,
};
next prev parent reply other threads:[~2022-08-29 7:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 4:48 [PATCH V7 0/8] perf: Expand perf_branch_entry Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 1/8] perf: Add system error and not in transaction branch types Anshuman Khandual
2022-08-26 22:15 ` [tip: perf/core] " tip-bot2 for Anshuman Khandual
2022-08-29 7:50 ` tip-bot2 for Anshuman Khandual [this message]
2022-08-24 4:48 ` [PATCH V7 2/8] perf: Extend branch type classification Anshuman Khandual
2022-08-26 22:15 ` [tip: perf/core] " tip-bot2 for Anshuman Khandual
2022-08-29 7:50 ` tip-bot2 for Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 3/8] perf: Capture branch privilege information Anshuman Khandual
2022-08-26 22:15 ` [tip: perf/core] " tip-bot2 for Anshuman Khandual
2022-08-29 7:50 ` tip-bot2 for Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 4/8] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-08-26 22:15 ` [tip: perf/core] " tip-bot2 for Anshuman Khandual
2022-08-29 7:49 ` tip-bot2 for Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 5/8] perf/tools: Add system error and not in transaction branch types Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 6/8] perf/tools: Extend branch type classification Anshuman Khandual
2022-08-30 21:11 ` Arnaldo Carvalho de Melo
2022-09-01 5:07 ` Anshuman Khandual
2022-09-02 17:31 ` Arnaldo Carvalho de Melo
2022-09-02 17:46 ` Arnaldo Carvalho de Melo
2022-09-05 8:00 ` Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 7/8] perf/tools: Add branch privilege information request flag Anshuman Khandual
2022-08-24 4:48 ` [PATCH V7 8/8] perf/tools: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-08-25 10:22 ` [PATCH V7 0/8] perf: Expand perf_branch_entry Peter Zijlstra
2022-08-29 4:12 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166175940238.401.10445533628526721258.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=anshuman.khandual@arm.com \
--cc=james.clark@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®