mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: linux-kernel@vger.kernel.org,
	Dmitry Rokosov <DDRokosov@sberdevices.ru>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops
Date: Mon, 05 Sep 2022 18:44:19 +0100	[thread overview]
Message-ID: <166239985949.822508.8248374962835676727.b4-ty@kernel.org> (raw)
In-Reply-To: <20220901132336.33234-1-andriy.shevchenko@linux.intel.com>

On Thu, 1 Sep 2022 16:23:34 +0300, Andy Shevchenko wrote:
> If the buffer pointer is NULL we already are in troubles since
> regmap bulk API expects caller to provide valid parameters,
> it dereferences that without any checks before we call for
> traces.
> 
> Moreover, the current code will print garbage in the case of
> buffer is NULL and length is not 0.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/3] regmap: trace: Remove useless check for NULL for bulk ops
      commit: f78d5e1168e08429bc948d09b6dc11fec5e019f7
[2/3] regmap: trace: Remove explicit castings
      commit: d10268a50bdbc03ebb6d340d63bf78c44d7c66a8
[3/3] regmap: trace: Remove unneeded blank lines
      commit: 6ed406ef9f74372282c3b515e64986120823f769

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      parent reply	other threads:[~2022-09-05 17:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 13:23 Andy Shevchenko
2022-09-01 13:23 ` [PATCH v1 2/3] regmap: trace: Remove explicit castings Andy Shevchenko
2022-09-01 13:31   ` Mark Brown
2022-09-01 14:18     ` Andy Shevchenko
2022-09-01 14:46       ` Steven Rostedt
2022-09-01 14:50         ` Mark Brown
2022-09-01 15:28           ` Steven Rostedt
2022-09-01 22:22   ` Dmitry Rokosov
2022-09-01 13:23 ` [PATCH v1 3/3] regmap: trace: Remove unneeded blank lines Andy Shevchenko
2022-09-01 22:22   ` Dmitry Rokosov
2022-09-01 22:20 ` [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Dmitry Rokosov
2022-09-05 17:44 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166239985949.822508.8248374962835676727.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=DDRokosov@sberdevices.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®