From: Rob Herring <robh@kernel.org>
To: Julius Werner <jwerner@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Jian-Jia Su <jjsu@google.com>,
Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH 3/4 v2] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings
Date: Thu, 08 Sep 2022 07:35:00 -0500 [thread overview]
Message-ID: <1662640500.327192.2262539.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220907232914.243502-3-jwerner@chromium.org>
On Wed, 07 Sep 2022 16:29:13 -0700, Julius Werner wrote:
> This patch adds bindings for LPDDR4 and LPDDR5 memory analogous to the
> existing bindings for LPDDR2 and LPDDR3. For now, the new types are only
> needed for topology description, so other properties like timing
> parameters are omitted. They can be added later if needed.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> .../ddr/jedec,lpddr-props.yaml | 4 ++
> .../memory-controllers/ddr/jedec,lpddr4.yaml | 36 ++++++++++++++
> .../memory-controllers/ddr/jedec,lpddr5.yaml | 47 +++++++++++++++++++
> 3 files changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
>
> Changelog:
>
> - v2
> - removed minItems
> - moved `$ref` below `maintainers`
> - renamed example node from `lpddr4` to `lpddr`
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.example.dtb: lpddr: Unevaluated properties are not allowed ('manufacturer-id' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.example.dtb: lpddr: Unevaluated properties are not allowed ('manufacturer-id' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-09-08 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:29 [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings Julius Werner
2022-09-07 23:29 ` [PATCH 2/4 v2] dt-bindings: memory: Add numeric LPDDR compatible string variant Julius Werner
2022-09-12 21:37 ` Rob Herring
2022-09-07 23:29 ` [PATCH 3/4 v2] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
2022-09-08 12:35 ` Rob Herring [this message]
2022-09-08 14:04 ` Krzysztof Kozlowski
2022-09-09 23:23 ` Julius Werner
2022-09-07 23:29 ` [PATCH 4/4 v2] dt-bindings: memory: Add jedec,lpddrX-channel binding Julius Werner
2022-09-08 14:00 ` [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings Krzysztof Kozlowski
2022-09-12 21:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662640500.327192.2262539.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=jjsu@google.com \
--cc=jwerner@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®