From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Hector Martin" <marcan@marcan.st>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Sven Peter" <sven@svenpeter.dev>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error
Date: Wed, 14 Sep 2022 17:47:31 +0200 [thread overview]
Message-ID: <166317043943.2639676.3222680734266270030.b4-ty@kernel.org> (raw)
In-Reply-To: <YxatO5OaI2RpxQ2M@google.com>
On Mon, 5 Sep 2022 19:15:23 -0700, Dmitry Torokhov wrote:
> The driver allocates reset GPIO in apple_pcie_setup_port() but neither
> releases the resource, nor uses devm API to have it released
> automatically.
>
> Let's fix this by switching to devm API. While at it let's use generic
> devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node()
> - this will allow us top stop exporting the latter down the road.
>
> [...]
Applied to pci/apple, thanks!
[1/1] PCI: apple: do not leak reset GPIO on unbind/unload/error
https://git.kernel.org/lpieralisi/pci/c/a6b9ede1f3df
Thanks,
Lorenzo
prev parent reply other threads:[~2022-09-14 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 2:15 Dmitry Torokhov
2022-09-06 7:09 ` Marc Zyngier
2022-09-06 7:13 ` Hector Martin
2022-09-09 9:16 ` Lorenzo Pieralisi
2022-09-09 12:48 ` Marc Zyngier
2022-09-14 15:47 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166317043943.2639676.3222680734266270030.b4-ty@kernel.org \
--to=lpieralisi@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®