From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: skashyap@marvell.com, Letu Ren <fantasquex@gmail.com>,
jejb@linux.ibm.com, jhasan@marvell.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, Wende Tan <twd2.me@gmail.com>,
Zheyu Ma <zheyuma97@gmail.com>,
linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH] scsi: qedf: Fix a UAF bug in __qedf_probe
Date: Thu, 15 Sep 2022 23:01:55 -0400 [thread overview]
Message-ID: <166329729477.12731.17768877694121234425.b4-ty@oracle.com> (raw)
In-Reply-To: <20211112120641.16073-1-fantasquex@gmail.com>
On Fri, 12 Nov 2021 20:06:41 +0800, Letu Ren wrote:
> In __qedf_probe, if `qedf->cdev` is NULL which means
> qed_ops->common->probe() failed, then the program will goto label err1,
> scsi_host_put() will free `lport->host` pointer. Because the memory `qedf`
> points to is allocated by libfc_host_alloc(), it will be freed by
> scsi_host_put(). However, the if statement below label err0 only checks
> whether qedf is NULL but doesn't check whether the memory has been freed.
> So a UAF bug occurred.
>
> [...]
Applied to 6.0/scsi-fixes, thanks!
[1/1] scsi: qedf: Fix a UAF bug in __qedf_probe
https://git.kernel.org/mkp/scsi/c/fbfe96869b78
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-09-16 3:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 12:06 Letu Ren
2022-01-03 6:47 ` [EXT] " Saurav Kashyap
2022-09-06 10:00 ` Letu Ren
2022-09-06 11:04 ` Saurav Kashyap
2022-09-16 3:01 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166329729477.12731.17768877694121234425.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=fantasquex@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jhasan@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=skashyap@marvell.com \
--cc=twd2.me@gmail.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®