From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com
Cc: linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org,
greg@kroah.com
Subject: Re: [PATCH] 2.6 PPC64: EEH notifier call chain
Date: Sun, 18 Jul 2004 02:05:45 +1000 [thread overview]
Message-ID: <16633.20057.434313.475775@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040707152412.F21634@forte.austin.ibm.com>
Linas,
> Please review and forward upstream as appropriate.
Sorry for the delay; have been on vacation.
> This patch implements a notifier call chain for EEH, as per pervious emails.
> When an EEH slot freeze is detected, it is placed on a workqueue, from
> whence it is dispatched to any regiistered notify callbacks. The goal
> of the qorkqueue is to pull the slot-freeze detection out of an interrupt
> context. As before, this patch only handles events for ethernet controllers;
> I'll try to broaden the scope in future revisions.
I don't like the way we are making a policy decision here that
ethernet devices can be recovered but other devices can't. I would
much rather call the notifier for all EEH events and have the notify
callback(s) make the decision. That could be either the hotplug
driver or the device driver itself. We get a return value from
notifier_call_chain that could be used to communicate that back to
eeh.c, if that is useful.
Regards,
Paul.
prev parent reply other threads:[~2004-07-17 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-07 20:24 linas
2004-07-17 16:05 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16633.20057.434313.475775@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=greg@kroah.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®