mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Jiri Slaby" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jiri Slaby <jslaby@suse.cz>, Borislav Petkov <bp@suse.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/misc] x86/dumpstack: Don't mention RIP in "Code: "
Date: Tue, 20 Sep 2022 14:23:49 -0000	[thread overview]
Message-ID: <166368382994.401.4342298770580161949.tip-bot2@tip-bot2> (raw)
In-Reply-To: <b772c39f-c5ae-8f17-fe6e-6a2bc4d1f83b@kernel.org>

The following commit has been merged into the x86/misc branch of tip:

Commit-ID:     5258b80e60da6d8908ae2846b234ed8d9d9d4a19
Gitweb:        https://git.kernel.org/tip/5258b80e60da6d8908ae2846b234ed8d9d9d4a19
Author:        Jiri Slaby <jslaby@suse.cz>
AuthorDate:    Tue, 06 Sep 2022 09:11:23 +02:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 20 Sep 2022 16:11:54 +02:00

x86/dumpstack: Don't mention RIP in "Code: "

Commit

  238c91115cd0 ("x86/dumpstack: Fix misleading instruction pointer error message")

changed the "Code:" line in bug reports when RIP is an invalid pointer.
In particular, the report currently says (for example):

  BUG: kernel NULL pointer dereference, address: 0000000000000000
  ...
  RIP: 0010:0x0
  Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.

That

  Unable to access opcode bytes at RIP 0xffffffffffffffd6.

is quite confusing as RIP value is 0, not -42. That -42 comes from
"regs->ip - PROLOGUE_SIZE", because Code is dumped with some prologue
(and epilogue).

So do not mention "RIP" on this line in this context.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/b772c39f-c5ae-8f17-fe6e-6a2bc4d1f83b@kernel.org
---
 arch/x86/kernel/dumpstack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index afae4dd..b3dba35 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -128,7 +128,7 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl)
 		/* No access to the user space stack of other tasks. Ignore. */
 		break;
 	default:
-		printk("%sCode: Unable to access opcode bytes at RIP 0x%lx.\n",
+		printk("%sCode: Unable to access opcode bytes at 0x%lx.\n",
 		       loglvl, prologue);
 		break;
 	}

  parent reply	other threads:[~2022-09-20 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  8:37 6.0 tty regression, NULL pointer deref in flush_to_ldisc Hans de Goede
2022-08-29  9:16 ` Weird RIP printed in BUGs [was: 6.0 tty regression, NULL pointer deref in flush_to_ldisc] Jiri Slaby
2022-09-06  7:11   ` [PATCH] x86/dumpstack: Don't mention RIP in "Code:" Jiri Slaby
2022-09-07  3:45     ` Borislav Petkov
2022-09-20 14:23   ` tip-bot2 for Jiri Slaby [this message]
2022-08-29  9:36 ` 6.0 tty regression, NULL pointer deref in flush_to_ldisc Ilpo Järvinen
2022-08-29 10:11   ` Hans de Goede
2022-08-29 21:25   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166368382994.401.4342298770580161949.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bp@suse.de \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®