From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: houlong.wei@mediatek.com, linux-kernel@vger.kernel.org,
jassisinghbrar@gmail.com, linux-arm-kernel@lists.infradead.org,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v4] dt-bindings: mailbox: Convert mtk-gce to DT schema
Date: Mon, 3 Oct 2022 09:58:18 -0500 [thread overview]
Message-ID: <166480909049.2249063.7109234696871106188.robh@kernel.org> (raw)
In-Reply-To: <20220921090006.37642-1-angelogioacchino.delregno@collabora.com>
On Wed, 21 Sep 2022 11:00:06 +0200, AngeloGioacchino Del Regno wrote:
> Convert the mtk-gce mailbox binding to DT schema format.
>
> During the conversion, the examples for client device/mutex nodes
> were removed, as these are found in their respective bindings:
> arm/mediatek/mediatek,mmsys.yaml for "mediatek,mt8173-mmsys"
> soc/mediatek/mediatek,mutex.yaml for "mediatek,mt8173-disp-mutex"
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>
> Changes in v4:
> - Removed deprecated examples comment
> - Fixed address for gce example
> - clock-names variation is now in allOf block
> - Added soc bus node with two address/size cells, as to
> provide a more practical example for the gce node
>
> Changes in v3:
> - Removed '|' from description
> - Removed mbox client examples
> - Squashed patch dt-bindings: arm: mediatek:
> mmsys: Reference to mediatek,gce-mailbox.yaml
>
> Changes in v2:
> - Changed mtk-gce.txt references to new yaml file
>
>
> A previous attempt for this was made at [1], but it was changing
> the way of getting clocks (by name for all).
> Keeping clock-names not required for the multi-gce case makes this
> binding simpler, hence I chose to abandon the change at [1] and go
> for this one instead.
>
> Any Reviewed-by or Acked-by tag was dropped, as this conversion was
> completely redone from scratch and differs from [1] for the
> aforementioned reasons.
>
> [1]: https://lore.kernel.org/all/20220524151512.247435-1-angelogioacchino.delregno@collabora.com/
>
> .../bindings/arm/mediatek/mediatek,mmsys.yaml | 3 +-
> .../mailbox/mediatek,gce-mailbox.yaml | 85 +++++++++++++++++++
> .../devicetree/bindings/mailbox/mtk-gce.txt | 82 ------------------
> 3 files changed, 87 insertions(+), 83 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> delete mode 100644 Documentation/devicetree/bindings/mailbox/mtk-gce.txt
>
Applied, thanks!
prev parent reply other threads:[~2022-10-03 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:00 AngeloGioacchino Del Regno
2022-09-21 9:15 ` Krzysztof Kozlowski
2022-10-03 14:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166480909049.2249063.7109234696871106188.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®