From: Rob Herring <robh@kernel.org>
To: Julius Werner <jwerner@chromium.org>
Cc: devicetree@vger.kernel.org, Jian-Jia Su <jjsu@google.com>,
Dmitry Osipenko <digetx@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4 v5] dt-bindings: memory: Add jedec,lpddrX-channel binding
Date: Mon, 3 Oct 2022 12:52:15 -0500 [thread overview]
Message-ID: <166481953479.2504015.9253665477423699363.robh@kernel.org> (raw)
In-Reply-To: <20220930220606.303395-4-jwerner@chromium.org>
On Fri, 30 Sep 2022 15:06:06 -0700, Julius Werner wrote:
> This patch adds a new device tree binding for an LPDDR channel to serve
> as a top-level organizing node for LPDDR part nodes nested below it. An
> LPDDR channel needs to have an "io-width" property to describe its width
> (this is important because this width does not always match the io-width
> of the part number, indicating that multiple parts are wired in parallel
> on the same channel), as well as one or more nested "rank@X" nodes.
> Those represent information about the individual ranks of each LPDDR
> part connected on that channel and should match the existing
> "jedec,lpddrX" bindings for individual LPDDR parts.
>
> New platforms should be using this node -- the existing practice of
> providing a raw, toplevel "jedec,lpddrX" node without indication of how
> many identical parts are in the system should be considered deprecated.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> .../ddr/jedec,lpddr-channel.yaml | 146 ++++++++++++++++++
> .../ddr/jedec,lpddr-props.yaml | 10 +-
> 2 files changed, 155 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-channel.yaml
>
> Changelog:
>
> - v2:
> - changed $ref for rank subnode to specifically match LPDDR type in
> compatible string
> - moved `reg` up to be listed right below `compatible`
> - v3:
> - no changes
> - v4:
> - no changes
> - v5:
> - no changes
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-10-03 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 22:06 [PATCH 1/4 v5] dt-bindings: memory: Factor out common properties of LPDDR bindings Julius Werner
2022-09-30 22:06 ` [PATCH 2/4 v5] dt-bindings: memory: Add numeric LPDDR compatible string variant Julius Werner
2022-09-30 22:06 ` [PATCH 3/4 v5] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
2022-09-30 22:06 ` [PATCH 4/4 v5] dt-bindings: memory: Add jedec,lpddrX-channel binding Julius Werner
2022-10-03 17:52 ` Rob Herring [this message]
2022-10-18 15:10 ` [PATCH 1/4 v5] dt-bindings: memory: Factor out common properties of LPDDR bindings Krzysztof Kozlowski
2022-10-18 17:04 ` Krzysztof Kozlowski
2022-10-18 21:36 ` Julius Werner
2022-10-18 21:37 ` Krzysztof Kozlowski
2022-10-26 17:03 ` Krzysztof Kozlowski
2022-10-26 23:04 ` Julius Werner
2022-10-27 13:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166481953479.2504015.9253665477423699363.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=jjsu@google.com \
--cc=jwerner@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®