From: Jeff Moyer <jmoyer@redhat.com>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Fix netpoll cleanup on abort without dev
Date: Wed, 4 Aug 2004 10:54:01 -0400 [thread overview]
Message-ID: <16656.63625.650665.626364@segfault.boston.redhat.com> (raw)
In-Reply-To: <20040804142049.GL16310@waste.org>
==> Regarding [PATCH] Fix netpoll cleanup on abort without dev; Matt Mackall <mpm@selenic.com> adds:
mpm> If netpoll attempts to use a device without polling support, it will
mpm> oops when shutting down. This adds a check that we've actually
mpm> attached to a device.
Hi, Matt,
Perhaps I'm missing something, but how do we successfully return from
netpoll_setup without np->dev filled in? Netpoll_setup has the following:
if (!ndev->poll_controller) {
printk(KERN_ERR "%s: %s doesn't support polling, aborting.\n",
np->name, np->dev_name);
goto release;
}
Thanks,
Jeff
next prev parent reply other threads:[~2004-08-04 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 14:20 Matt Mackall
2004-08-04 14:54 ` Jeff Moyer [this message]
2004-08-04 15:11 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16656.63625.650665.626364@segfault.boston.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®