From: Rob Herring <robh@kernel.org>
To: Jeff Chang <richtek.jeff.chang@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jeff <jeff_chang@richtek.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
robh+dt@kernel.org, jeff_chang@ricthek.com,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz
Subject: Re: [PATCH] ASoC: Add Richtek RT5512 Speaker Amp Driver
Date: Thu, 13 Oct 2022 06:22:44 -0500 [thread overview]
Message-ID: <166565993196.4194034.3763255376639766451.robh@kernel.org> (raw)
In-Reply-To: <20221013080643.6509-1-richtek.jeff.chang@gmail.com>
On Thu, 13 Oct 2022 16:06:43 +0800, Jeff Chang wrote:
> From: Jeff <jeff_chang@richtek.com>
>
> The RT5512 is a boosted class-D amplifier with V/I sensing.
> A built-in DC-DC step-up converter is used to provide efficient power for
> class-D amplifier with multi-level class-H operation. The digital audio
> interface supports I2S, left-justified, right-justified and TDM format for
> audio in with a data out used for chip information like voltage sense and
> current sense, which are able to be monitored via DATAO pin through proper
> register setting.
>
> Signed-off-by: SHIH CHIA CHANG <jeff_chang@richtek.com>
> ---
> .../bindings/sound/richtek,rt5512.yaml | 50 +
> sound/soc/codecs/Kconfig | 10 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/rt5512.c | 860 ++++++++++++++++++
> 4 files changed, 922 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/richtek,rt5512.yaml
> create mode 100644 sound/soc/codecs/rt5512.c
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/sound/richtek,rt5512.example.dtb:0:0: /example-0/i2c/rt5512@5c: failed to match any schema with compatible: ['richtek,rt5512']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-10-13 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 8:06 Jeff Chang
2022-10-13 11:22 ` Rob Herring [this message]
2022-10-13 12:00 ` Mark Brown
2022-10-13 12:46 ` Liao, Bard
2022-10-13 13:05 ` Mark Brown
2022-10-13 14:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166565993196.4194034.3763255376639766451.robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jeff_chang@richtek.com \
--cc=jeff_chang@ricthek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=richtek.jeff.chang@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®