From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD5E0C433FE for ; Sun, 16 Oct 2022 23:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbiJPXXJ (ORCPT ); Sun, 16 Oct 2022 19:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiJPXXG (ORCPT ); Sun, 16 Oct 2022 19:23:06 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D291C2D77C for ; Sun, 16 Oct 2022 16:23:05 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id s3so6822130qtn.12 for ; Sun, 16 Oct 2022 16:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D2YKjKjr/Iqhytm7HQxGJmcY+ib/Qdg9cNU3yBgPhck=; b=SwDTvufwiN1eCsa8868EcV7Jt1pk4Ew6nZKhghXJLs2+DM23wm2GxI5FUHrmRiiC5p Lz+bshugc4O559q0+RHnw8CT4KkDxRMtSdT9Fj+4CQ/EVlpK6Ghe5T83uPS2o5C8t0Eq tGZc3IdT4fjd/vd9y+SI1kOzTrjO3m7uwv9/ucrTlWYD15dDMCPfIEIdU2RRD5gui3gW /6sVlqOJE3Y24NNft+48F2hREfhrtXdxJ1KWLkseDl2GIhhwG1hC4BWKPmw47k39AZvZ ScWeSPqbgCapYyPduiIwxILlB8jsQvt/7nGxncgU0NqYPpOKXswASRGVoymB904+u5vx 6DEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D2YKjKjr/Iqhytm7HQxGJmcY+ib/Qdg9cNU3yBgPhck=; b=xNvdqSAQ/2gmrQOgXJ8vaTJSMD8LzJtIVa7VqrfHtegCzRPOpHibE0k2nLz918ote/ lqLUSI/7VIaaRSTCZcKsWpihaHw31Z+qXTxie7cryqOdBWWVk+oLHww6AoZCCkUfo7DF eW5/Aw4qITKzfpeidKjle2aH+KpQNLPNrQg8V6y8pAyunnP65TmovonCDzCgUy0Y8MnC kfZeJALh+4gkoi/SurQCnScdF9dxjUNr+tUkBExEhEan7wv9fNSgivLbWfCg3J69zXOr bMIsGt+Ilvv43gQ7HrRVqU0CccorfxyM1kdOA3dw/Q7HU5ItEovtKf0ZD7dLaFsUDkBe hgEw== X-Gm-Message-State: ACrzQf3GieXsp1t7rSUVvOjeOdYjOP2EgPgPOkBaIYEKCYoaqEA8W/ex P6IQGioAr7PP22X20RkeyrVH8XqhMkBTkoFb X-Google-Smtp-Source: AMsMyM7DmNkIX93gUNRD6AhHpjgtw942VFTuB/nlonmEnCVrh2HKOywJwR0A82bLSIh0rRdmrXOpeQ== X-Received: by 2002:ac8:5dcb:0:b0:39c:ce78:47a1 with SMTP id e11-20020ac85dcb000000b0039cce7847a1mr6742897qtx.615.1665962584717; Sun, 16 Oct 2022 16:23:04 -0700 (PDT) Received: from [127.0.0.1] ([8.46.73.120]) by smtp.gmail.com with ESMTPSA id cm16-20020a05622a251000b00399b73d06f0sm6693624qtb.38.2022.10.16.16.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 16:23:04 -0700 (PDT) From: Jens Axboe To: ming.lei@redhat.com, Yu Kuai , john.garry@huawei.com, hare@suse.de Cc: linux-block@vger.kernel.org, yukuai3@huawei.com, linux-kernel@vger.kernel.org, yi.zhang@huawei.com In-Reply-To: <20221011142253.4015966-1-yukuai1@huaweicloud.com> References: <20221011142253.4015966-1-yukuai1@huaweicloud.com> Subject: Re: [PATCH v2] blk-mq: fix null pointer dereference in blk_mq_clear_rq_mapping() Message-Id: <166596258175.7979.3302811091883290568.b4-ty@kernel.dk> Date: Sun, 16 Oct 2022 17:23:01 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Oct 2022 22:22:53 +0800, Yu Kuai wrote: > From: Yu Kuai > > Our syzkaller report a null pointer dereference, root cause is > following: > > __blk_mq_alloc_map_and_rqs > set->tags[hctx_idx] = blk_mq_alloc_map_and_rqs > blk_mq_alloc_map_and_rqs > blk_mq_alloc_rqs > // failed due to oom > alloc_pages_node > // set->tags[hctx_idx] is still NULL > blk_mq_free_rqs > drv_tags = set->tags[hctx_idx]; > // null pointer dereference is triggered > blk_mq_clear_rq_mapping(drv_tags, ...) > > [...] Applied, thanks! [1/1] blk-mq: fix null pointer dereference in blk_mq_clear_rq_mapping() commit: 76dd298094f484c6250ebd076fa53287477b2328 Best regards, -- Jens Axboe