From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, mhiramat@kernel.org,
Ye Bin <yebin@huaweicloud.com>,
rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH v3 0/3] fix possible memleak in '__blk_trace_remove'
Date: Thu, 20 Oct 2022 06:03:31 -0700 [thread overview]
Message-ID: <166627101165.162941.2701658237902573676.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221019033602.752383-1-yebin@huaweicloud.com>
On Wed, 19 Oct 2022 11:35:59 +0800, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
>
> Diff v3 VS v2
> 1. Invert the check of 'blk_trace_{start,stop}' and return early from the
> function for the error case.
>
> Diff v2 VS v1:
> 1. Introduce 'blk_trace_{start,stop}' helper instead of 'blk_trace_switch_state'.
> 2. Move stop block trace from '__blk_trace_remove' to 'blk_trace_cleanup'.
>
> [...]
Applied, thanks!
[1/3] blktrace: introduce 'blk_trace_{start,stop}' helper
commit: 60a9bb9048f9e95029df10a9bc346f6b066c593c
[2/3] blktrace: fix possible memleak in '__blk_trace_remove'
commit: dcd1a59c62dc49da75539213611156d6db50ab5d
[3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'
commit: 2db96217e7e515071726ca4ec791742c4202a1b2
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-10-20 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:35 Ye Bin
2022-10-19 3:36 ` [PATCH v3 1/3] blktrace: introduce 'blk_trace_{start,stop}' helper Ye Bin
2022-10-20 8:04 ` Christoph Hellwig
2022-10-19 3:36 ` [PATCH v3 2/3] blktrace: fix possible memleak in '__blk_trace_remove' Ye Bin
2022-10-20 8:04 ` Christoph Hellwig
2022-10-19 3:36 ` [PATCH v3 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown' Ye Bin
2022-10-20 8:04 ` Christoph Hellwig
2022-10-20 13:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166627101165.162941.2701658237902573676.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®