mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Sean Anderson <sean.anderson@seco.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	geert@linux-m68k.org, madalin.bucur@nxp.com, edumazet@google.com,
	camelia.groza@nxp.com, kuba@kernel.org, andrew@lunn.ch,
	afd@ti.com, linux-kernel@vger.kernel.org, pabeni@redhat.com,
	madalin.bucur@oss.nxp.com
Subject: Re: [PATCH net v2] net: fman: Use physical address for userspace interfaces
Date: Mon, 24 Oct 2022 09:50:16 +0000	[thread overview]
Message-ID: <166660501621.28227.3493718376720166675.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221020155041.2448668-1-sean.anderson@seco.com>

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 20 Oct 2022 11:50:41 -0400 you wrote:
> Before 262f2b782e25 ("net: fman: Map the base address once"), the
> physical address of the MAC was exposed to userspace in two places: via
> sysfs and via SIOCGIFMAP. While this is not best practice, it is an
> external ABI which is in use by userspace software.
> 
> The aforementioned commit inadvertently modified these addresses and
> made them virtual. This constitutes and ABI break.  Additionally, it
> leaks the kernel's memory layout to userspace. Partially revert that
> commit, reintroducing the resource back into struct mac_device, while
> keeping the intended changes (the rework of the address mapping).
> 
> [...]

Here is the summary with links:
  - [net,v2] net: fman: Use physical address for userspace interfaces
    https://git.kernel.org/netdev/net/c/c99f0f7e6837

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2022-10-24  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 15:50 Sean Anderson
2022-10-24  9:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166660501621.28227.3493718376720166675.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=camelia.groza@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome