From: "tip-bot2 for Rafael Mendonca" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Rafael Mendonca <rafaelmendsr@gmail.com>,
Borislav Petkov <bp@suse.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/sev] virt/sev-guest: Remove unnecessary free in init_crypto()
Date: Fri, 28 Oct 2022 06:43:07 -0000 [thread overview]
Message-ID: <166693938775.29415.2368858785626989918.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20221018015425.887891-1-rafaelmendsr@gmail.com>
The following commit has been merged into the x86/sev branch of tip:
Commit-ID: c6fbb759d68898aad40e57d09ed18df6094a1874
Gitweb: https://git.kernel.org/tip/c6fbb759d68898aad40e57d09ed18df6094a1874
Author: Rafael Mendonca <rafaelmendsr@gmail.com>
AuthorDate: Mon, 17 Oct 2022 22:54:25 -03:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Thu, 27 Oct 2022 14:24:18 +02:00
virt/sev-guest: Remove unnecessary free in init_crypto()
If the memory allocation for the auth tag fails, then there is no need
to free it.
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20221018015425.887891-1-rafaelmendsr@gmail.com
---
drivers/virt/coco/sev-guest/sev-guest.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index f422f9c..e9704ae 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -152,12 +152,10 @@ static struct snp_guest_crypto *init_crypto(struct snp_guest_dev *snp_dev, u8 *k
crypto->a_len = crypto_aead_authsize(crypto->tfm);
crypto->authtag = kmalloc(crypto->a_len, GFP_KERNEL_ACCOUNT);
if (!crypto->authtag)
- goto e_free_auth;
+ goto e_free_iv;
return crypto;
-e_free_auth:
- kfree(crypto->authtag);
e_free_iv:
kfree(crypto->iv);
e_free_crypto:
prev parent reply other threads:[~2022-10-28 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 1:54 [PATCH] virt: sev-guest: " Rafael Mendonca
2022-10-28 6:43 ` tip-bot2 for Rafael Mendonca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166693938775.29415.2368858785626989918.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=rafaelmendsr@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®