From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBD5C433FE for ; Sat, 29 Oct 2022 13:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbiJ2NBR (ORCPT ); Sat, 29 Oct 2022 09:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiJ2NBK (ORCPT ); Sat, 29 Oct 2022 09:01:10 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2E605FDD0 for ; Sat, 29 Oct 2022 06:01:07 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oolSE-0006ID-NZ; Sat, 29 Oct 2022 15:00:50 +0200 From: Heiko Stuebner To: John Keeping , dri-devel@lists.freedesktop.org Cc: Heiko Stuebner , linux-arm-kernel@lists.infradead.org, Daniel Vetter , Johan Jonker , linux-rockchip@lists.infradead.org, Thomas Zimmermann , Sandy Huang , linux-kernel@vger.kernel.org, David Airlie Subject: Re: [PATCH] drm/rockchip: fix fbdev on non-IOMMU devices Date: Sat, 29 Oct 2022 15:00:46 +0200 Message-Id: <166704843772.1532410.11915201216204142960.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221020181248.2497065-1-john@metanate.com> References: <20221020181248.2497065-1-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Oct 2022 19:12:47 +0100, John Keeping wrote: > When switching to the generic fbdev infrastructure, it was missed that > framebuffers were created with the alloc_kmap parameter to > rockchip_gem_create_object() set to true. The generic infrastructure > calls this via the .dumb_create() driver operation and thus creates a > buffer without an associated kmap. > > alloc_kmap only makes a difference on devices without an IOMMU, but when > it is missing rockchip_gem_prime_vmap() fails and the framebuffer cannot > be used. > > [...] Applied, thanks! [1/1] drm/rockchip: fix fbdev on non-IOMMU devices commit: ab78c74cfc5a3caa2bbb7627cb8f3bca40bb5fb0 Best regards, -- Heiko Stuebner