mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: mpm@selenic.com
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL
Date: Mon, 16 Aug 2004 18:38:08 -0400	[thread overview]
Message-ID: <16673.14160.843507.617388@segfault.boston.redhat.com> (raw)

Hi, Matt,

I believe that we should export the netpoll_set_trap routine as GPL only,
since vendors could conceivably use it to by-pass the networking stack
completely.  Jeff, correct me if I'm wrong, but I think this is what you
intended when you commented on it many months ago (sorry, can't find the
thread).

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

--- linux-2.6.7/net/core/netpoll.c.gpl	2004-08-16 17:11:52.773312560 -0400
+++ linux-2.6.7/net/core/netpoll.c	2004-08-16 17:12:42.146806648 -0400
@@ -678,8 +678,8 @@ void netpoll_set_trap(int trap)
 		atomic_dec(&trapped);
 }
 
-EXPORT_SYMBOL(netpoll_set_trap);
-EXPORT_SYMBOL(netpoll_trap);
+EXPORT_SYMBOL_GPL(netpoll_set_trap);
+EXPORT_SYMBOL_GPL(netpoll_trap);
 EXPORT_SYMBOL(netpoll_parse_options);
 EXPORT_SYMBOL(netpoll_setup);
 EXPORT_SYMBOL(netpoll_cleanup);

             reply	other threads:[~2004-08-16 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-16 22:38 Jeff Moyer [this message]
2004-08-16 23:12 ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16673.14160.843507.617388@segfault.boston.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®