From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF11FA3743 for ; Tue, 1 Nov 2022 11:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiKALAE (ORCPT ); Tue, 1 Nov 2022 07:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbiKALAA (ORCPT ); Tue, 1 Nov 2022 07:00:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBF7E178BC; Tue, 1 Nov 2022 03:59:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A48B4B81B0F; Tue, 1 Nov 2022 10:59:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B9B7C433D6; Tue, 1 Nov 2022 10:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667300397; bh=dKEuaYyyAw0/iFBymiu6NLIfDXb4VFkaxpP0t9sFQn0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=YDcgPJMnCwXLtF5ZBJ3e1vZ/8v2eo7+N0HdsMyBc+vncFG3OJjUegJDLOw5agKDC6 1PbS+8y7XUGCrZq2OEylHUwrkPxiot5IQSbbHxOLN5A5yiNy5AP6A3Ybhe/rzB9nSe mVHPDaYWrZbdn/zEpk4w9fay9MbCjrhimbME64d3n/T0DpvUScGkjbGICgaKX7YInb aCsGQ0Be3hl5+REJpUwAN90sH8PM1aaxhQLnJ39aTMMCQLY0VdQfxv/oQX+WzdYdmF cL5T8VBwE7XNQ4mfexmuTJMuPORfqpwTjLu5dvUKISvMFgBp5BRNB+Tb5kd9ZgE005 9lv1AEyuofzAA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [next] wifi: atmel: Fix atmel_private_handler array size From: Kalle Valo In-Reply-To: <20221018023732.never.700-kees@kernel.org> References: <20221018023732.never.700-kees@kernel.org> To: Kees Cook Cc: Simon Kelley , Kees Cook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166730039237.21401.8200103649620545525.kvalo@kernel.org> Date: Tue, 1 Nov 2022 10:59:54 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook wrote: > Fix the atmel_private_handler to correctly sized (1 element) again. (I > should have checked the data segment for differences.) This had no > behavioral impact (no private callbacks), but it made a very large > zero-filled array. > > Cc: Simon Kelley > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Fixes: 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes") > Signed-off-by: Kees Cook Patch applied to wireless-next.git, thanks. 8b860466b137 wifi: atmel: Fix atmel_private_handler array size -- https://patchwork.kernel.org/project/linux-wireless/patch/20221018023732.never.700-kees@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches