From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC34EC43217 for ; Tue, 8 Nov 2022 10:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233840AbiKHKRC (ORCPT ); Tue, 8 Nov 2022 05:17:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233376AbiKHKRA (ORCPT ); Tue, 8 Nov 2022 05:17:00 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41938A45C; Tue, 8 Nov 2022 02:16:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9A64B816DD; Tue, 8 Nov 2022 10:16:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F441C433D6; Tue, 8 Nov 2022 10:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667902616; bh=aiZ1rVErp+MnWyEzbTE6C+1D5vFOLe8Gr860yiFpIuI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=vL/Bk2pJGYCA7ODdJo3ynX+zuOGHu7pOJ0vFgnV0lviMrRVwU4PMiTyag3ErYku3O cwAEw7MTNfcdAyXtrI0+wmUtZcIQjkBy6V6LL9u95oHtMnHLVISxjiQXQfOTt6XW7g yeTouuylWi6mOImb2MJLsxwqyBirLc3b0BS9GiHQjEpgg4eex2VUKAEQSxBwYjPmRm 0FYjBnhR8SARrZhjRXG5LUyu3DRFW7++ZsDj+3S5s0juEAn/TWvKPitazrYBdyQBJ0 AWlMjc4XrkuJZ8199aw0Tog6Y7iYZIayt/ztLpYs6eCOPsnAxtjMJ8AMa6kyLNAyiM Mvy906mvhtoyQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: ath11k: Trigger sta disconnect on hardware restart From: Kalle Valo In-Reply-To: <20221104085403.11025-1-quic_youghand@quicinc.com> References: <20221104085403.11025-1-quic_youghand@quicinc.com> To: Youghandhar Chintala Cc: , , , Youghandhar Chintala , kernel test robot User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166790261226.18646.8349764958072116285.kvalo@kernel.org> Date: Tue, 8 Nov 2022 10:16:55 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Youghandhar Chintala wrote: > Currently after the hardware restart triggered from the driver, the > station interface connection remains intact, since a disconnect trigger > is not sent to userspace. This can lead to a problem in targets where > the wifi mac sequence is added by the firmware. > > After the target restart, its wifi mac sequence number gets reset to > zero. Hence AP to which our device is connected will receive frames with > a wifi mac sequence number jump to the past, thereby resulting in the > AP dropping all these frames, until the frame arrives with a wifi mac > sequence number which AP was expecting. > > To avoid such frame drops, its better to trigger a station disconnect > upon target hardware restart which can be done with API > ieee80211_reconfig_disconnect exposed to mac80211. > > The other targets are not affected by this change, since the hardware > params flag is not set. > > Reported-by: kernel test robot > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > > Signed-off-by: Youghandhar Chintala > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a018750a2cce wifi: ath11k: Trigger sta disconnect on hardware restart -- https://patchwork.kernel.org/project/linux-wireless/patch/20221104085403.11025-1-quic_youghand@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches