From: Jens Axboe <axboe@kernel.dk>
To: Sagi Grimberg <sagi@grimberg.me>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Scott Bauer <scott.bauer@intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>,
Keith Busch <kbusch@kernel.org>,
Rafael Antognolli <Rafael.Antognolli@intel.com>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
linux-nvme@lists.infradead.org,
Serge Semin <fancer.lancer@gmail.com>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: sed-opal: kmalloc the cmd/resp buffers
Date: Tue, 08 Nov 2022 10:35:57 -0700 [thread overview]
Message-ID: <166792895795.7601.10122514732945288817.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221107203944.31686-1-Sergey.Semin@baikalelectronics.ru>
On Mon, 7 Nov 2022 23:39:44 +0300, Serge Semin wrote:
> In accordance with [1] the DMA-able memory buffers must be
> cacheline-aligned otherwise the cache writing-back and invalidation
> performed during the mapping may cause the adjacent data being lost. It's
> specifically required for the DMA-noncoherent platforms [2]. Seeing the
> opal_dev.{cmd,resp} buffers are implicitly used for DMAs in the NVME and
> SCSI/SD drivers in framework of the nvme_sec_submit() and sd_sec_submit()
> methods respectively they must be cacheline-aligned to prevent the denoted
> problem. One of the option to guarantee that is to kmalloc the buffers
> [2]. Let's explicitly allocate them then instead of embedding into the
> opal_dev structure instance.
>
> [...]
Applied, thanks!
[1/1] block: sed-opal: kmalloc the cmd/resp buffers
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-11-08 17:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 22:46 [PATCH v2 0/3] block/nvme: Fix DMA-noncoherent platforms support Serge Semin
2022-09-29 22:46 ` [PATCH v2 1/3] nvme-hwmon: Return error on kzalloc failure Serge Semin
2022-09-29 23:53 ` Keith Busch
2022-09-30 9:52 ` Serge Semin
2022-09-30 14:57 ` Keith Busch
2022-10-04 14:50 ` Serge Semin
2022-10-04 17:33 ` Keith Busch
2022-10-07 10:01 ` Serge Semin
2022-09-29 22:46 ` [PATCH v2 2/3] nvme-hwmon: Kmalloc the NVME SMART log buffer Serge Semin
2022-10-17 7:18 ` Christoph Hellwig
2022-10-17 16:16 ` Serge Semin
2022-10-18 14:49 ` Christoph Hellwig
2022-09-29 22:46 ` [PATCH v2 3/3] block: sed-opal: Cache-line-align the cmd/resp buffers Serge Semin
2022-10-03 18:24 ` Jonathan Derrick
2022-10-04 15:32 ` Serge Semin
2022-11-07 20:39 ` [PATCH v3] block: sed-opal: kmalloc " Serge Semin
2022-11-08 6:22 ` Christoph Hellwig
2022-11-08 17:35 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166792895795.7601.10122514732945288817.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Rafael.Antognolli@intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=axboe@fb.com \
--cc=fancer.lancer@gmail.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®