mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Shouldn't kconfig defaults match recommendations in help text?
Date: Tue, 24 Aug 2004 17:01:04 +0200	[thread overview]
Message-ID: <16683.22576.781038.756277@alkaid.it.uu.se> (raw)
In-Reply-To: <Pine.LNX.4.61.0408232347380.3767@dragon.hygekrogen.localhost>

Jesper Juhl writes:
 > [quote]
 > 
 > The processor's performance-monitoring counters are special-purpose
 > global registers. This option adds support for virtual per-process
 > performance-monitoring counters which only run when the process
 > to which they belong is executing. This improves the accuracy of
 > performance measurements by reducing "noise" from other processes.
 > 
 > Say Y.
 > 
 >   Virtual performance counters support (PERFCTR_VIRTUAL) [N/y/?] (NEW)
 > 
 > [/quote]
 > 
 > 
 > I just picked the above randomly, there are several other cases like it.
 > 
 > The comment clearly makes a recommendation that the user enables (in this 
 > case) the option, yet the default is the exact opposite. What is the point 
 > in that?
 > I don't see anything but confusion amongst users as the result of such 
 > inconsistency.

This particular mismatch occurs because the Kconfig entry
doesn't have a "default" line, so Kconfig defaults to "n".

It makes little sense to disable PERFCTR_VIRTUAL when
PERFCTR is enabled, so providing a "default y" for
PERFCTR_VIRTUAL is the right thing to do.
(It's an option because the design allows several
independent high-level services on top of the low-level
code. Currently there's only one high-level service in
2.6-mm, but with several it's reasonable to allow users
to enable only those they actually want.)

 > Would patches to change default configuration choices to match the 
 > recommendation given in the help text (if any) be acceptable? If not I'd 
 > be interrested in the reasons why not.
 > 
 > If such patches are acceptable/wanted I'll be happy to supply them.

Feel free to do so :-)

/Mikael

  reply	other threads:[~2004-08-24 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-23 21:50 Jesper Juhl
2004-08-24 15:01 ` Mikael Pettersson [this message]
2004-08-24 17:03   ` Jesper Juhl
2004-08-24 18:29     ` Sam Ravnborg
2004-08-24 19:33       ` Jesper Juhl
2004-08-24 20:46         ` Sam Ravnborg
2004-08-24 21:14           ` Jesper Juhl
  -- strict thread matches above, loose matches on Subject: below --
2004-08-23 18:57 Jesper Juhl
2004-08-24 18:52 ` Roman Zippel
2004-08-24 19:36   ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16683.22576.781038.756277@alkaid.it.uu.se \
    --to=mikpe@csd.uu.se \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®