From: Paul Mackerras <paulus@samba.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: anton@samba.org, linuxppc64-dev@lists.linuxppc.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6 PPC64: Another log buffer length patch.
Date: Thu, 26 Aug 2004 12:09:31 +1000 [thread overview]
Message-ID: <16685.18011.723499.446490@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040825200138.GN14002@austin.ibm.com>
Linas,
> ===== arch/ppc64/kernel/ras.c 1.15 vs edited =====
> --- 1.15/arch/ppc64/kernel/ras.c Mon Aug 2 03:00:41 2004
> +++ edited/arch/ppc64/kernel/ras.c Wed Aug 25 14:46:33 2004
> @@ -108,6 +108,7 @@
>
> ras_get_sensor_state_token = rtas_token("get-sensor-state");
> ras_check_exception_token = rtas_token("check-exception");
> + rtas_get_error_log_max();
Why do we do this call, given that we don't use the result? Is there
something time-critical about some future call, such that we want to
have fetched the value at this point? If there is, it needs a comment
here, if not, let's remove this call.
Regards,
Paul.
next prev parent reply other threads:[~2004-08-26 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-25 20:01 Linas Vepstas
2004-08-26 2:09 ` Paul Mackerras [this message]
2004-08-26 16:06 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16685.18011.723499.446490@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=anton@samba.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®