From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888ACC43219 for ; Wed, 16 Nov 2022 09:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233722AbiKPJd7 (ORCPT ); Wed, 16 Nov 2022 04:33:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231985AbiKPJdr (ORCPT ); Wed, 16 Nov 2022 04:33:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E28D425FD; Wed, 16 Nov 2022 01:33:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A414B81C21; Wed, 16 Nov 2022 09:33:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ED18C433D6; Wed, 16 Nov 2022 09:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668591224; bh=LJFi6Ma1wzYiDa5KLD8RjmUBaaBhQpd9Xx8w7okLL/0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=EJiPSar9fvYC8gxWIGNiU+SsZZ4gALbqU+ctlrwbqFlvFTAg49j5d5rebYCOq7eMh gHL2BUnvPCavqP+szIAv9HWDFrFGby4a35IKJ89s9lrBLLUOagDLTxbxbZ5LD5oe1y xvJ+DA+yWSohkqAM0Hv6H2gRr6RoBOmkSnb5aV5HpIkCGN5O03cA1DaazSNJZwds4m /2QMLb7ywnQtlXMLoLjH2jCCnzUMD5ORDn8ytoMHr1h42COptFk9Q1ap5XVY50G3Rh tZcW7hE3wOHMav2vqPQcIfVyXCHn3Zpwij88EGFveOGfPbe0uQM84U98TcfpFsy1/k 5PaEB2i1656AA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() From: Kalle Valo In-Reply-To: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> References: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: Ping-Ke Shih , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166859121959.16887.13694175362892729527.kvalo@kernel.org> Date: Wed, 16 Nov 2022 09:33:41 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe JAILLET wrote: > 'ret' is not updated after a function call in rtw89_core_sta_assoc(). > This prevent error handling from working. > > Add the missing assignment. > > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Christophe JAILLET > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 81c0b8928437 wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() -- https://patchwork.kernel.org/project/linux-wireless/patch/7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches