mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Edmund Berenson <edmund.berenson@emlix.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Lukasz Zemla <Lukasz.Zemla@woodward.com>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation
Date: Sun, 20 Nov 2022 09:09:22 -0600	[thread overview]
Message-ID: <166895687829.3066801.11111948596761204211.robh@kernel.org> (raw)
In-Reply-To: <20221120124543.18973-1-edmund.berenson@emlix.com>


On Sun, 20 Nov 2022 13:45:43 +0100, Edmund Berenson wrote:
> - Add the ad7927 compatibility string, with fallback compatibility
> to ad7928.
> - ad7923 and ad7924 are treated the same in the driver, show
> the relationship in the documentation.
> 
> Suggested-by: Lukasz Zemla <Lukasz.Zemla@woodward.com>
> Signed-off-by: Edmund Berenson <edmund.berenson@emlix.com>
> ---
>  .../bindings/iio/adc/adi,ad7923.yaml          | 21 +++++++++++--------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml:32:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7923.example.dtb: adc@0: compatible: 'oneOf' conditional failed, one must be fixed:
	['adi,ad7928'] is too short
	'adi,ad7904' was expected
	'adi,ad7914' was expected
	'adi,ad7923' was expected
	'adi,ad7908' was expected
	'adi,ad7918' was expected
	'adi,ad7927' was expected
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7923.example.dtb: adc@0: Unevaluated properties are not allowed ('compatible' was unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221120124543.18973-1-edmund.berenson@emlix.com

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.


  reply	other threads:[~2022-11-20 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 10:44 [PATCH 1/2] iio/adc: add ad7927 compatibility to ad7923 drivers Edmund Berenson
2022-11-16 10:44 ` [PATCH 2/2] iio/adc: add documentation for adc ad7927 Edmund Berenson
2022-11-16 11:13   ` Krzysztof Kozlowski
2022-11-16 19:12   ` Jonathan Cameron
2022-11-20 12:45     ` [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation Edmund Berenson
2022-11-20 15:09       ` Rob Herring [this message]
2022-11-20 15:34       ` Rob Herring
2022-11-20 17:06         ` [PATCH v3] " Edmund Berenson
2022-11-21  9:13           ` Krzysztof Kozlowski
2022-11-21 10:26             ` Edmund Berenson
2022-11-21 10:31               ` Krzysztof Kozlowski
2022-11-21 10:45                 ` Edmund Berenson
2022-11-21 11:15                   ` Krzysztof Kozlowski
2022-11-21 12:45                   ` Jonathan Cameron
2022-11-21 16:16                     ` Krzysztof Kozlowski
2022-11-16 19:10 ` [PATCH 1/2] iio/adc: add ad7927 compatibility to ad7923 drivers Jonathan Cameron
2022-11-20 12:42   ` [PATCH v2 1/2] iio: adc: ad7923: Add ad7927 Edmund Berenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166895687829.3066801.11111948596761204211.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Lukasz.Zemla@woodward.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edmund.berenson@emlix.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®