mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Marvin Lin <milkfafa@gmail.com>
Cc: kflin@nuvoton.com, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, avifishman70@gmail.com,
	kwliu@nuvoton.com, openbmc@lists.ozlabs.org, tmaimon77@gmail.com,
	linux-kernel@vger.kernel.org, tali.perry1@gmail.com,
	mchehab@kernel.org
Subject: Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine
Date: Tue, 22 Nov 2022 14:28:34 -0600	[thread overview]
Message-ID: <166914597689.442814.4178753345805789388.robh@kernel.org> (raw)
In-Reply-To: <20221122085724.3245078-3-milkfafa@gmail.com>


On Tue, 22 Nov 2022 16:57:19 +0800, Marvin Lin wrote:
> Add dt-binding document for Video Capture/Differentiation Engine (VCD)
> and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.
> 
> Signed-off-by: Marvin Lin <milkfafa@gmail.com>
> ---
>  .../bindings/media/nuvoton,npcm-video.yaml    | 87 +++++++++++++++++++
>  1 file changed, 87 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml: properties:nuvoton,syscon-gcr: 'oneOf' conditional failed, one must be fixed:
	'type' is a required property
		hint: A vendor boolean property can use "type: boolean"
	Additional properties are not allowed ('$ref' was unexpected)
		hint: A vendor boolean property can use "type: boolean"
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml: properties:nuvoton,syscon-gcr: 'oneOf' conditional failed, one must be fixed:
		'enum' is a required property
		'const' is a required property
		hint: A vendor string property with exact values has an implicit type
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	'/schemas/types.yaml#definitions/phandle' does not match 'types.yaml#/definitions/'
		hint: A vendor property needs a $ref to types.yaml
	'/schemas/types.yaml#definitions/phandle' does not match '^#/(definitions|\\$defs)/'
		hint: A vendor property can have a $ref to a a $defs schema
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml: properties:nuvoton,syscon-gfxi: 'oneOf' conditional failed, one must be fixed:
	'type' is a required property
		hint: A vendor boolean property can use "type: boolean"
	Additional properties are not allowed ('$ref' was unexpected)
		hint: A vendor boolean property can use "type: boolean"
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml: properties:nuvoton,syscon-gfxi: 'oneOf' conditional failed, one must be fixed:
		'enum' is a required property
		'const' is a required property
		hint: A vendor string property with exact values has an implicit type
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	'/schemas/types.yaml#definitions/phandle' does not match 'types.yaml#/definitions/'
		hint: A vendor property needs a $ref to types.yaml
	'/schemas/types.yaml#definitions/phandle' does not match '^#/(definitions|\\$defs)/'
		hint: A vendor property can have a $ref to a a $defs schema
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221122085724.3245078-3-milkfafa@gmail.com

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.


  reply	other threads:[~2022-11-22 20:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  8:57 [PATCH v7 0/7] Support Nuvoton NPCM Video Capture/Encode Engine Marvin Lin
2022-11-22  8:57 ` [PATCH v7 1/7] ARM: dts: nuvoton: Add node for NPCM VCD and ECE engine Marvin Lin
2022-11-22  8:57 ` [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings " Marvin Lin
2022-11-22 20:28   ` Rob Herring [this message]
2022-11-23  0:05   ` Rob Herring
2022-11-24  3:45     ` Kun-Fa Lin
2022-11-22  8:57 ` [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI Marvin Lin
2022-11-23 15:59   ` Krzysztof Kozlowski
2022-11-24  3:53     ` Kun-Fa Lin
2022-11-22  8:57 ` [PATCH v7 4/7] media: v4l: Add HEXTILE compressed format Marvin Lin
2022-11-22  8:57 ` [PATCH v7 5/7] media: v4l2-ctrls: Reserve user control base for NPCM video controls Marvin Lin
2022-11-22  8:57 ` [PATCH v7 6/7] media: uapi: Add controls for NPCM video driver Marvin Lin
2022-11-23  8:11   ` kernel test robot
2022-11-23  8:21   ` kernel test robot
2022-11-22  8:57 ` [PATCH v7 7/7] media: nuvoton: Add driver for NPCM video capture and encode engine Marvin Lin
2022-11-22 12:21   ` Andrzej Pietrasiewicz
2022-11-24  3:30     ` Kun-Fa Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166914597689.442814.4178753345805789388.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=avifishman70@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kflin@nuvoton.com \
    --cc=kwliu@nuvoton.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=milkfafa@gmail.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®