From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752185AbeAZIBX (ORCPT ); Fri, 26 Jan 2018 03:01:23 -0500 Received: from mga02.intel.com ([134.134.136.20]:65515 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbeAZIBW (ORCPT ); Fri, 26 Jan 2018 03:01:22 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="13625169" Subject: Re: [PATCH 1/2] mmc: sdhci: Add support for O2 eMMC HS200 mode To: "ernest.zhang" , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shirley.her@bayhubtech.com, yuxiang.wan@bayhubtech.com, xiaoguang.yu@bayhubtech.com References: <20180117013734.4120-1-ernest.zhang@bayhubtech.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <166d204a-094d-7636-8174-329d8bb781c0@intel.com> Date: Fri, 26 Jan 2018 10:00:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180117013734.4120-1-ernest.zhang@bayhubtech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/18 03:37, ernest.zhang wrote: > when eMMC used as boot device, the eMMC signaling voltage is tied to 1.8v > fixed output voltage, bios can set o2 sd host controller PCI configuration > register 0x308 bit4 to 1 to let host controller skip try 3.3.v signaling > voltage and direct use 1.8v singling voltage in eMMC initialize process. > > Signed-off-by: ernest.zhang Please use version numbers in the patch subject. This was V3, the next is V4. A summary of what has changed (after the --- line or in the cover email) is also expected. > --- > drivers/mmc/host/sdhci-pci-o2micro.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c > index 555970a29c94..8855a416ffd4 100644 > --- a/drivers/mmc/host/sdhci-pci-o2micro.c > +++ b/drivers/mmc/host/sdhci-pci-o2micro.c > @@ -1,8 +1,9 @@ > /* > - * Copyright (C) 2013 BayHub Technology Ltd. > + * Copyright (C) 2018 BayHub Technology Ltd. > * > * Authors: Peter Guo > * Adam Lee > + * Ernest Zhang > * > * This software is licensed under the terms of the GNU General Public > * License version 2, as published by the Free Software Foundation, and > @@ -39,6 +40,7 @@ > #define O2_SD_MISC_CTRL4 0xFC > #define O2_SD_TUNING_CTRL 0x300 > #define O2_SD_PLL_SETTING 0x304 > +#define O2_SD_MISC_SETTING 0x308 > #define O2_SD_CLK_SETTING 0x328 > #define O2_SD_CAP_REG2 0x330 > #define O2_SD_CAP_REG0 0x334 > @@ -53,6 +55,7 @@ > > #define O2_SD_VENDOR_SETTING 0x110 > #define O2_SD_VENDOR_SETTING2 0x1C8 > +#define O2_SD_HW_TUNING_ENABLE BIT(4) This is not used in this patch which means it should be in the other patch > > static void o2_pci_set_baseclk(struct sdhci_pci_chip *chip, u32 value) > { > @@ -184,6 +187,7 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot) > struct sdhci_pci_chip *chip; > struct sdhci_host *host; > u32 reg; > + int ret; > > chip = slot->chip; > host = slot->host; > @@ -197,6 +201,20 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot) > if (reg & 0x1) > host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12; > > + if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD0) { > + ret = pci_read_config_dword(chip->pdev, > + O2_SD_MISC_SETTING, ®); > + if (ret) > + return -EIO; > + if (reg & (1 << 4)) { > + pr_info("%s: emmc 1.8v flag is set, force 1.8v signaling voltage\n", > + mmc_hostname(host->mmc)); > + host->flags &= ~SDHCI_SIGNALING_330; > + host->flags |= SDHCI_SIGNALING_180; > + } > + } > + > + Please do not add double blank line > if (chip->pdev->device != PCI_DEVICE_ID_O2_FUJIN2) > break; > /* set dll watch dog timer */ >