From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95CEC001DF for ; Mon, 24 Jul 2023 16:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbjGXQPB (ORCPT ); Mon, 24 Jul 2023 12:15:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjGXQO6 (ORCPT ); Mon, 24 Jul 2023 12:14:58 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92A0210F4; Mon, 24 Jul 2023 09:14:34 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36OCfMaY030671; Mon, 24 Jul 2023 16:14:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=TtvQqxKfQENg6OBymyu8tFNUuF8IkWECHw84hJtPBu4=; b=NQmNc4QVizgJ55xfPrlgNrRBLJ6ZieEP22isA9qbcuqT3mXbekMnVGsSwAoPxZIQrNZ+ A0p75uxQB6VjEQOdECbxHD6HHYxfkF565B4kbJCt4aQd9LOByIFb9gS3v/avRZ/8rZYM 8JA+j78tn911V2w8bbr0IhzdNEem1KRinw5KNecrU8EI4vnCG5GEA2IQjPov1P1KlGSm A0m0t02nhGOp/XSIMGtweJ42+EWViL5AMlpeN4qs+wmg1baGXvd58w4IBCYmq/t2Z+JS k8Ye73PXvJZoTe5/qO8vNTllWI1AnxDQLa52A9NP9Wl51OsVgAoHcmK4tAFZvdRE9kyF pA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1qcyrryr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jul 2023 16:14:30 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36OGETws025051 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jul 2023 16:14:29 GMT Received: from [10.216.25.90] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 24 Jul 2023 09:14:22 -0700 Message-ID: <166e73d1-a158-2da8-09ea-541fbc3241dc@quicinc.com> Date: Mon, 24 Jul 2023 21:44:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 2/6] soc: qcom: llcc: Refactor llcc driver to support multiple configuration Content-Language: en-US To: Krzysztof Kozlowski , Komal Bajaj , , , , , , , CC: , , References: <20230724084155.8682-1-quic_kbajaj@quicinc.com> <20230724084155.8682-3-quic_kbajaj@quicinc.com> <39b4bafd-410f-cae8-13ae-e18d751b51a2@quicinc.com> From: Mukesh Ojha In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: G3IscAaM-atrdnxruu2vSGbDm7G5XfnZ X-Proofpoint-GUID: G3IscAaM-atrdnxruu2vSGbDm7G5XfnZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-24_12,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 mlxscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307240144 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/2023 6:56 PM, Krzysztof Kozlowski wrote: > On 24/07/2023 14:28, Mukesh Ojha wrote: >> On 7/24/2023 2:11 PM, Komal Bajaj wrote: >>> Refactor driver to support multiple configuration for llcc on a target. >>> >>> Signed-off-by: Komal Bajaj >>> --- >>> drivers/soc/qcom/llcc-qcom.c | 264 +++++++++++++++++++++++------------ >>> 1 file changed, 178 insertions(+), 86 deletions(-) >>> >>> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c >>> index 67c19ed2219a..321f8d2079f7 100644 >>> --- a/drivers/soc/qcom/llcc-qcom.c >>> +++ b/drivers/soc/qcom/llcc-qcom.c >>> @@ -127,6 +127,12 @@ struct qcom_llcc_config { >>> bool no_edac; >>> }; >>> >>> +struct qcom_sct_config >> >> const ? > > What (and how) should be const above? left over, thanks for catching.. -Mukesh > > Best regards, > Krzysztof >