mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Josh Boyer <jwboyer@jdub.homelinux.org>
Cc: anton@au.bim.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH Trivial] ppc64:  Use STACK_FRAME_OVERHEAD macro in misc.S
Date: Fri, 10 Sep 2004 09:33:08 +1000	[thread overview]
Message-ID: <16704.59444.785268.367031@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1094772116.16444.81.camel@67-41-71-119.roch.qwest.net>

Josh Boyer writes:

> I found a couple places where a hardcoded value for the stack frame was
> used instead of the STACK_FRAME_OVERHEAD macro.  The following patch
> fixes that.

Using STACK_FRAME_OVERHEAD here would be purely arbitrary (i.e. the
112 here has no connection with the stack frames established in head.S
and entry.S).  This function needs a stack frame and 112 bytes is the
minimum size specified by the ABI.  I think it's quite clear as it is.

Paul.

  reply	other threads:[~2004-09-09 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-09 23:21 Josh Boyer
2004-09-09 23:33 ` Paul Mackerras [this message]
2004-09-10  0:02   ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16704.59444.785268.367031@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=anton@au.bim.com \
    --cc=jwboyer@jdub.homelinux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®