mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Chancel Liu <chancel.liu@nxp.com>
Subject: Re: [PATCH] ASoC: soc-pcm.c: Clear DAIs parameters after stream_active is updated
Date: Wed, 07 Dec 2022 21:04:59 +0000	[thread overview]
Message-ID: <167044709968.572887.4310845274377067555.b4-ty@kernel.org> (raw)
In-Reply-To: <20221128060950.3540845-1-chancel.liu@nxp.com>

On Mon, 28 Nov 2022 14:09:50 +0800, Chancel Liu wrote:
> DAIs parameters should be cleared if there's no active stream. Before,
> we implemented it in soc_pcm_hw_free() by detecting stream_active. If
> the running stream is the last active stream, we're going to clear
> parameters.
> 
> However it will cause DAIs parameters never be cleared if there're
> more than one stream. For example, we have stream1 and stream2 about
> to stop. stream2 executes soc_pcm_hw_free() before stream1 executes
> soc_pcm_close(). At the moment, stream2 should clear DAIs parameters.
> Since stream_active is not yet updated by stream1 in soc_pcm_close(),
> stream2 will not clear DAIs parameters. In result both stream1 and
> stream2 don't clear the parameters.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-pcm.c: Clear DAIs parameters after stream_active is updated
      commit: 1da681e52853f0abfbfff8c69833d31e538ff9c0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      reply	other threads:[~2022-12-07 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  6:09 Chancel Liu
2022-12-07 21:04 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167044709968.572887.4310845274377067555.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=chancel.liu@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®