From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Pavel Machek <pavel@ucw.cz>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
shuzzle@mailbox.org
Subject: Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk
Date: Thu, 28 Jul 2016 01:29:49 +0200 [thread overview]
Message-ID: <1670639.GCDubuBUSI@vostro.rjw.lan> (raw)
In-Reply-To: <1703386.0Oti4h65x8@vostro.rjw.lan>
On Thursday, July 28, 2016 01:20:53 AM Rafael J. Wysocki wrote:
> On Wednesday, July 27, 2016 05:17:38 PM Josh Poimboeuf wrote:
> > On Thu, Jul 28, 2016 at 12:12:15AM +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, July 27, 2016 12:59:18 PM Josh Poimboeuf wrote:
> > > > Hm... I have a theory, but I'm not sure about it. I noticed that
> > > > x86_acpi_enter_sleep_state(),
> > >
> > > I think you mean x86_acpi_suspend_lowlevel().
> >
> > Oops!
> >
> > > > which is involved in suspend, overwrites
> > > > several global variables (e.g, initial_code) which are used by the CPU
> > > > boot code in head_64.S. But surprisingly, it doesn't restore those
> > > > variables to their original values after it resumes.
> > >
> > > Is the head_64.S code also used to bring up offline CPUs?
> >
> > Yes.
>
> OK
>
> So it is really interesting why and how that stuff works for everybody.
>
> Basically, CPU online should fail after a suspend-resume cycle, but it
> doesn't most of the time AFAICS.
do_boot_cpu() restores those values, so I think we're safe from that angle.
That should apply to the CPU online during resume from hibernation too.
Thanks,
Rafael
next prev parent reply other threads:[~2016-07-27 23:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 11:32 Rafael J. Wysocki
2016-07-26 14:04 ` Borislav Petkov
2016-07-26 20:24 ` Rafael J. Wysocki
2016-07-26 20:33 ` Kees Cook
2016-07-26 20:53 ` Rafael J. Wysocki
2016-07-26 20:59 ` Kees Cook
2016-07-26 21:17 ` Thomas Garnier
2016-07-27 5:39 ` Borislav Petkov
2016-07-26 14:39 ` Josh Poimboeuf
2016-07-26 20:15 ` Rafael J. Wysocki
2016-07-26 20:31 ` Kees Cook
2016-07-26 20:42 ` Rafael J. Wysocki
2016-07-26 21:53 ` Josh Poimboeuf
2016-07-26 22:42 ` Rafael J. Wysocki
2016-07-26 23:08 ` Rafael J. Wysocki
2016-07-27 17:59 ` Josh Poimboeuf
2016-07-27 22:12 ` Rafael J. Wysocki
2016-07-27 22:17 ` Josh Poimboeuf
2016-07-27 23:20 ` Rafael J. Wysocki
2016-07-27 23:29 ` Rafael J. Wysocki [this message]
2016-07-28 15:17 ` [PATCH] x86/asm/power: Fix hibernation return address corruption Josh Poimboeuf
2016-07-28 15:32 ` Josh Poimboeuf
2016-07-28 21:36 ` Rafael J. Wysocki
2016-07-29 7:16 ` Ingo Molnar
2016-07-27 22:20 ` Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1670639.GCDubuBUSI@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=shuzzle@mailbox.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®