From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-pm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Scot Doyle <lkml14@scotdoyle.com>,
Alan Stern <stern@rowland.harvard.edu>,
Dan Williams <dan.j.williams@intel.com>,
Julius Werner <jwerner@chromium.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Pratyush Anand <pratyush.anand@st.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] USB / PM: Allow USB devices to remain runtime-suspended when sleeping
Date: Fri, 03 Apr 2015 23:23:32 +0200 [thread overview]
Message-ID: <1670645.XN7urnStQD@vostro.rjw.lan> (raw)
In-Reply-To: <20150403204436.GB19867@dtor-ws>
On Friday, April 03, 2015 01:44:36 PM Dmitry Torokhov wrote:
> Hi Tomeu,
>
> On Fri, Apr 03, 2015 at 02:57:56PM +0200, Tomeu Vizoso wrote:
> > Have dev_pm_ops.prepare return 1 for USB devices, interfaces, endpoints
> > and ports so that USB devices can remain runtime-suspended when the
> > system goes to a sleep state, if their wakeup state is correct.
> >
> > Also enable runtime PM for endpoints, which is another requirement for
> > the above to work.
>
> After patching I think the 4th unrelated subsystem with stubs for
> prepare() I think it is pretty clear that this approach is not the right
> one.
>
> If your driver does not care about any children hanging off it there is
> dev->ignore_children flag that either already does what you want, or
> maybe needs adjusted to support your use case.
I wouldn't overload ignore_children with that meaning. That said adding
a "return 1 from device_prepare() if this is set" flag might be a good idea.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2015-04-03 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 12:57 [PATCH v2 0/7] Allow UVC " Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 1/7] Input: Implement dev_pm_ops.prepare in input_class Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 2/7] Input: Add input_dev.stay_runtime_suspended flag Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 3/7] [media] uvcvideo: Set " Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 4/7] [media] uvcvideo: Enable runtime PM of descendant devices Tomeu Vizoso
2015-04-04 12:33 ` Laurent Pinchart
2015-04-09 10:52 ` Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 5/7] [media] v4l2-core: Implement dev_pm_ops.prepare() Tomeu Vizoso
2015-07-03 18:08 ` Mauro Carvalho Chehab
2015-04-03 12:57 ` [PATCH v2 6/7] [media] media-devnode: Implement dev_pm_ops.prepare callback Tomeu Vizoso
2015-04-03 12:57 ` [PATCH v2 7/7] USB / PM: Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
2015-04-03 20:44 ` Dmitry Torokhov
2015-04-03 21:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1670645.XN7urnStQD@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=pratyush.anand@st.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tomeu.vizoso@collabora.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®