From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9A1C46467 for ; Tue, 20 Dec 2022 13:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233762AbiLTNBy (ORCPT ); Tue, 20 Dec 2022 08:01:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233572AbiLTNBu (ORCPT ); Tue, 20 Dec 2022 08:01:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105C7D139; Tue, 20 Dec 2022 05:01:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B6DCCB8120C; Tue, 20 Dec 2022 13:01:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03CF8C433D2; Tue, 20 Dec 2022 13:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671541306; bh=slrz46HiCnR36Ttz5lZwi2BzDl4AV9enAoKXs0qjmNM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=UXKqSGIOyQZvfv+enBZrb4w4rxIfUxpC8+O6/Z9APCEJ7LTp1RxkoilHrcPTfgiom A/E2K6hgvdTdkF+03z6Wj5wceZ7w0g4Z8H15BanUZR0qfQArf1zXWW/sviGezn9WKb 4aj/Q2APzcDuWMp8Fa+Bmz2Sc4iIjs2Ll0G76mH33aZiaC4l0TDEua3SGeEvgMdzXx Sx171OfV+uC4PIa+oqWFqrAmX7bQIRKhvgFo8N7a21xgMNkuqll2G8uhXkeuspPCpv fsU58EpwbZeqgaimp2KZsMWL6M8/Okvia8qgDROZWupSsfi9rV7MHI4Mf7OfKMb/Aa JlU8uG8IuNL7A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: mt76: mt7996: select CONFIG_RELAY From: Kalle Valo In-Reply-To: <20221215163133.4152299-1-arnd@kernel.org> References: <20221215163133.4152299-1-arnd@kernel.org> To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Arnd Bergmann , Shayne Chen , Sean Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167154130077.23629.13270502460080911055.kvalo@kernel.org> Date: Tue, 20 Dec 2022 13:01:42 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > From: Arnd Bergmann > > Without CONFIG_RELAY, the driver fails to link: > > ERROR: modpost: "relay_flush" [drivers/net/wireless/mediatek/mt76/mt7996/mt7996e.ko] undefined! > ERROR: modpost: "relay_switch_subbuf" [drivers/net/wireless/mediatek/mt76/mt7996/mt7996e.ko] undefined! > ERROR: modpost: "relay_open" [drivers/net/wireless/mediatek/mt76/mt7996/mt7996e.ko] undefined! > ERROR: modpost: "relay_reset" [drivers/net/wireless/mediatek/mt76/mt7996/mt7996e.ko] undefined! > ERROR: modpost: "relay_file_operations" [drivers/net/wireless/mediatek/mt76/mt7996/mt7996e.ko] undefined! > > The same change was done in mt7915 for the corresponding copy of the code. > > Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") > See-also: 988845c9361a ("mt76: mt7915: add support for passing chip/firmware debug data to user space") > Signed-off-by: Arnd Bergmann Patch applied to wireless.git, thanks. 37fc9ad1617a wifi: mt76: mt7996: select CONFIG_RELAY -- https://patchwork.kernel.org/project/linux-wireless/patch/20221215163133.4152299-1-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches