From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747D8C4167B for ; Thu, 22 Dec 2022 16:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbiLVQGQ (ORCPT ); Thu, 22 Dec 2022 11:06:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbiLVQGL (ORCPT ); Thu, 22 Dec 2022 11:06:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1CAE1E3EE; Thu, 22 Dec 2022 08:06:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B893B81AFD; Thu, 22 Dec 2022 16:06:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1247BC433D2; Thu, 22 Dec 2022 16:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671725168; bh=yH5TY+BXIUX/RtGMIoGIZ/+GUrwkUycltBr89jfW6OA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kZp+YfHMr6wiksQT7I204ywCiQ/ZCYyxBt3oQQsE3m4NctAR1KyfeXd0bD1pXcSMs +qOLhFqfhF1VMxRECQ+omYiuj12lydKmKyepy6hkw84uobOuYAErczthwW4KvD868i fO6IDDIe4DQ2bpC88iWDHPLw2PLxXqHOW2faAspKG6t2HH5cP/xkpKBiiS2+q3OCjA SSPebE58UWcvwt1XcCHG0953ukMg9GhZOCenSGxHct9S3DrE4UBuy7E2X+Zwtyq+eJ F7XBzh/oMP63MIPEL7MgurQhO8+kzUkoNTvLeo5HakCDdyHLVfKk2QsIMbpOIX6nMK U/WNxYG/bmNPQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [wireless,v2] wifi: wilc1000: fix potential memory leak in wilc_mac_xmit() From: Kalle Valo In-Reply-To: <1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com> References: <1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com> To: Zhang Changzhong Cc: Ajay Singh , Claudiu Beznea , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Johnny Kim , Greg Kroah-Hartman , Chris Park , Rachel Kim , "Nicolas Ferre" , Zhang Changzhong , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167172516319.8231.9400853979965474557.kvalo@kernel.org> Date: Thu, 22 Dec 2022 16:06:04 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhang Changzhong wrote: > The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add > dev_kfree_skb() to fix it. Compile tested only. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Zhang Changzhong Patch applied to wireless-next.git, thanks. deb962ec9e1c wifi: wilc1000: fix potential memory leak in wilc_mac_xmit() -- https://patchwork.kernel.org/project/linux-wireless/patch/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches