From: Jens Axboe <axboe@kernel.dk>
To: paolo.valente@linaro.org, jack@suse.cz,
Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
Date: Mon, 26 Dec 2022 12:11:26 -0700 [thread overview]
Message-ID: <167208188642.23141.13167280199462782271.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221226030605.1437081-1-yukuai1@huaweicloud.com>
On Mon, 26 Dec 2022 11:06:05 +0800, Yu Kuai wrote:
> Commit 64dc8c732f5c ("block, bfq: fix possible uaf for 'bfqq->bic'")
> will access 'bic->bfqq' in bic_set_bfqq(), however, bfq_exit_icq_bfqq()
> can free bfqq first, and then call bic_set_bfqq(), which will cause uaf.
>
> Fix the problem by moving bfq_exit_bfqq() behind bic_set_bfqq().
>
>
> [...]
Applied, thanks!
[1/1] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
commit: 246cf66e300b76099b5dbd3fdd39e9a5dbc53f02
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-12-26 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 3:06 Yu Kuai
2022-12-26 11:18 ` Jan Kara
2022-12-26 19:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167208188642.23141.13167280199462782271.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®