From: Rob Herring <robh@kernel.org>
To: andreas@rammhold.de
Cc: devicetree@vger.kernel.org, stable@vger.kernel.org,
John Crispin <john@phrozen.org>, Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] of/fdt: run soc memory setup when early_init_dt_scan_memory fails
Date: Tue, 3 Jan 2023 18:41:03 -0600 [thread overview]
Message-ID: <167279286226.159538.13769216021607958062.robh@kernel.org> (raw)
In-Reply-To: <20221223112748.2935235-1-andreas@rammhold.de>
On Fri, 23 Dec 2022 12:27:47 +0100, andreas@rammhold.de wrote:
> From: Andreas Rammhold <andreas@rammhold.de>
>
> If memory has been found early_init_dt_scan_memory now returns 1. If
> it hasn't found any memory it will return 0, allowing other memory
> setup mechanisms to carry on.
>
> Previously early_init_dt_scan_memory always returned 0 without
> distinguishing between any kind of memory setup being done or not. Any
> code path after the early_init_dt_scan memory call in the ramips
> plat_mem_setup code wouldn't be executed anymore. Making
> early_init_dt_scan_memory the only way to initialize the memory.
>
> Some boards, including my mt7621 based Cudy X6 board, depend on memory
> initialization being done via the soc_info.mem_detect function
> pointer. Those wouldn't be able to obtain memory and panic the kernel
> during early bootup with the message "early_init_dt_alloc_memory_arch:
> Failed to allocate 12416 bytes align=0x40".
>
> Fixes: 1f012283e936 ("of/fdt: Rework early_init_dt_scan_memory() to call directly")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andreas Rammhold <andreas@rammhold.de>
> ---
> arch/mips/ralink/of.c | 2 +-
> drivers/of/fdt.c | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2023-01-04 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 11:27 andreas
2023-01-04 0:41 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167279286226.159538.13769216021607958062.robh@kernel.org \
--to=robh@kernel.org \
--cc=andreas@rammhold.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®