From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934967AbdEKO1b (ORCPT ); Thu, 11 May 2017 10:27:31 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:58789 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934356AbdEKO10 (ORCPT ); Thu, 11 May 2017 10:27:26 -0400 X-AuditID: b6c32a38-f791a6d0000031eb-55-591474cb05ea From: Bartlomiej Zolnierkiewicz To: SF Markus Elfring Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] omapfb: Use devm_kcalloc() in vrfb_probe() Date: Thu, 11 May 2017 16:27:19 +0200 Message-id: <1672837.1nPA5UjCzD@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <4a7b1751-4319-4bde-cf26-2de2a4096c68@users.sourceforge.net> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42LZdlhTV/d0iUikwbtnohbnO5czW2y9JW1x ou8Dq8XlXXPYLGYv6WexWD//FpsDm8fxG9uZPJpOtbN6fN4kF8AcxWWTkpqTWZZapG+XwJWx eUZsQQdfxddpPSwNjEe4uxg5OSQETCQ+Tl7PBGGLSVy4t56ti5GLQ0hgB6PE3/lLoJzPjBI/ P6xkhelY9HkBO0RiLaPEqfU3WCCcr4wSzdNWsoNUsQlYSUxsX8XYxcjBISJgKvHnRAhIDTNI w82Jb5hBaoQF7CU6Dp4Hs1kEVCUWXn8PdgevgKbE+6dfweKiAl4SW/a1g8U5BTwluvf+Zoeo EZT4MfkeC4jNLCAvsW//VFYIW0fi7LF1jCDLJAT+s0l8WH+ZHeQICQFZiU0HmCE+cJFoaZ/A CGELS7w6voUdwpaSaHz5EBoW0xkltv+WgJizmVFi1e4JUEXWEoePX4Raxifx7msPK8R8XomO NiGIEg+JM78+Q+1ylLiyto8JEkBzGCXe3d3IOoFRfhaSH2Yh+WEWkh8WMDKvYhRLLSjOTU8t Niww0StOzC0uzUvXS87P3cQIThpaFjsY95zzOcQowMGoxMN7gl04Uog1say4MvcQowQHs5II ryYw5QjxpiRWVqUW5ccXleakFh9ilOZgURLnFV1/LUJIID2xJDU7NbUgtQgmy8TBKdXAKH2P pbfp5tIs/VohPaVtt3dcXVW3t/mt7f0dmiey311eJTDPlpdT/aDk951GUzfrCjVa5J/LuR96 /mDOXJ0z24Om7VU56WfecYXtoIuT68TXqe2tUf93ixw0zdcUeHRGMqin2efxoikrlDeoKYkq Rfk/e+Ky4drCyyfv/wiN46xMqZ2rKtcsqMRSnJFoqMVcVJwIAJz2DMUWAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t9jQd1TJSKRBl1LFSzOdy5ntth6S9ri RN8HVovLu+awWcxe0s9isX7+LTYHNo/jN7YzeTSdamf1+LxJLoA5ys0mIzUxJbVIITUvOT8l My/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Zm2fEFnTwVXyd 1sPSwHiEu4uRk0NCwERi0ecF7BC2mMSFe+vZQGwhgdWMEpMecXUxcgHZXxklti5bwAqSYBOw kpjYvoqxi5GDQ0TAVOLPiRCQGmaBtYwS6zdsA6sRFrCX6Dh4nhnEZhFQlVh4/T0TiM0roCnx /ulXsLiogJfEln3tYHFOAU+J7r2/2SGWzWOUaDz8hRmiQVDix+R7LCA2s4C8xL79U1khbC2J 9TuPM01gFJiFpGwWkrJZSMoWMDKvYuRKLSjOTc8tNiow3MQIjJNth7X8dzD+OBt9iFGAg1GJ h/fEXOFIIdbEsuLK3EOMEhzMSiK8msAoE+JNSaysSi3Kjy8qzUktPsRoCvTTRGYp0eR8YAzn lcQbmlgamRiYmRkaGRibKYnzTgj8EiEkkJ5YkpqdmlqQWgTTx8TBKdXAyHHmVuDB8ohP+hIn C4v2PJonKvNFLG/7V96AgwLNDFoyl/anvY5bFumxcG7wNYv8ult/V7zPqYwv497O8Eu+rVpO IPjwKiehNcuDtXKOX1uioKT82m3/TZszFv+C+SI5NX7F7JMyebirk/NeyY0WM7N5Oiu6Tewk ba/1lhx5zmD98ZNi05FTSizFGYmGWsxFxYkAVtuH7qkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170511142722epcas1p26441aa94f4533f5614ca76296817537e X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170426092018epcas4p343e69e32255faa796e7c55c3e89e40f2 X-RootMTR: 20170426092018epcas4p343e69e32255faa796e7c55c3e89e40f2 References: <4a7b1751-4319-4bde-cf26-2de2a4096c68@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, April 26, 2017 11:20:07 AM SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 11:08:30 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/omap2/omapfb/vrfb.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c > index f346b02eee1d..54b51a7a290a 100644 > --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c > +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c > @@ -358,11 +358,7 @@ static int __init vrfb_probe(struct platform_device *pdev) > return PTR_ERR(vrfb_base); > > num_ctxs = pdev->num_resources - 1; > - > - ctxs = devm_kzalloc(&pdev->dev, > - sizeof(struct vrfb_ctx) * num_ctxs, > - GFP_KERNEL); > - > + ctxs = devm_kcalloc(&pdev->dev, num_ctxs, sizeof(*ctxs), GFP_KERNEL); This change makes the resulting binary larger by 24 bytes (probably because of the need to have an additional function argument) and I don't see an improvement from a security POV (pdev->num_resources is based on the size of static tables from arch/arm/mach-omap2/fb.c). I'm sorry but I'm not applying this patch. > if (!ctxs) > return -ENOMEM; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics