From: Rob Herring <robh@kernel.org>
To: "Martin Zaťovič" <m.zatovic1@gmail.com>
Cc: hemantk@codeaurora.org, bvanassche@acm.org, tzimmermann@suse.de,
iwona.winiarska@intel.com, dipenp@nvidia.com,
quic_jhugo@quicinc.com, gregkh@linuxfoundation.org,
mani@kernel.org, Michael.Srba@seznam.cz,
linux-kernel@vger.kernel.org, fmdefrancesco@gmail.com,
andersson@kernel.org, jason.m.bills@linux.intel.com,
ogabbay@kernel.org, jae.hyun.yoo@linux.intel.com,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, robh+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: add Wiegand controller dt-binding documentation
Date: Wed, 04 Jan 2023 20:53:58 -0600 [thread overview]
Message-ID: <167288699863.3289839.678028969383210.robh@kernel.org> (raw)
In-Reply-To: <20230104133414.39305-2-m.zatovic1@gmail.com>
On Wed, 04 Jan 2023 14:34:12 +0100, Martin Zaťovič wrote:
> A Weigand bus is defined by a Wiegand controller node. This node
> can contain one or more device nodes for devices attached to
> the controller(it is advised to only connect one device as Wiegand
> is a point-to-point bus).
>
> Wiegand controller needs to specify several attributes such as
> the pulse length in order to function properly. These attributes
> are documented here.
>
> Signed-off-by: Martin Zaťovič <m.zatovic1@gmail.com>
> ---
> .../bindings/wiegand/wiegand-controller.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/wiegand/wiegand-controller.example.dts:20.40-41 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/wiegand/wiegand-controller.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230104133414.39305-2-m.zatovic1@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-01-05 2:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 13:34 [PATCH 0/3] Wiegand bus driver and GPIO controller driver Martin Zaťovič
2023-01-04 13:34 ` [PATCH 1/3] dt-bindings: add Wiegand controller dt-binding documentation Martin Zaťovič
2023-01-05 2:53 ` Rob Herring [this message]
2023-01-05 2:53 ` Rob Herring
2023-01-08 16:30 ` Rob Herring
2023-01-22 14:21 ` Krzysztof Kozlowski
2023-01-04 13:34 ` [PATCH 2/3] bus: add Wiegand bus driver Martin Zaťovič
2023-01-04 14:03 ` Greg KH
2023-01-04 14:05 ` Greg KH
2023-01-25 13:05 ` Martin Zaťovič
2023-01-25 13:16 ` Arnd Bergmann
2023-01-25 13:21 ` Martin Zaťovič
2023-01-25 13:26 ` Greg KH
2023-01-25 13:37 ` Martin Zaťovič
2023-01-04 14:06 ` Greg KH
2023-01-04 13:34 ` [PATCH 3/3] wiegand: add Wiegand GPIO bit-banged controller driver Martin Zaťovič
2023-01-04 14:05 ` Greg KH
2023-01-04 16:39 ` kernel test robot
2023-01-04 16:59 ` Andy Shevchenko
2023-01-04 17:01 ` Andy Shevchenko
2023-01-25 9:28 ` Martin Zaťovič
2023-01-25 11:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167288699863.3289839.678028969383210.robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Srba@seznam.cz \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=iwona.winiarska@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.zatovic1@gmail.com \
--cc=mani@kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®